linux-kernel - Re: [PATCH v2 2/2] serial: imx: disable console clocks on unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211021083915.4rpku6mtwzb2gqiv@pengutronix.de>
Date:   Thu, 21 Oct 2021 10:39:15 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Francesco Dolcini <francesco.dolcini@...adex.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] serial: imx: disable console clocks on unregister

On Wed, Oct 20, 2021 at 09:26:43PM +0200, Francesco Dolcini wrote:
> During console setup imx_uart_console_setup() enables clocks, but they
> are never disabled when the console is unregistered, this leads to
> clk_prepare_enable() being called multiple times without a matching
> clk_disable_unprepare() in case of console unregister.
> 
> Ensure that clock enable/disable are balanced adding
> clk_disable_unprepare() in the console exit callback.
> 
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)