linux-kernel - Re: [PATCH] mm/page_alloc: use clamp() to simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60939c5c-2b1f-a7d7-61b3-f8f501a4893f@redhat.com>
Date:   Thu, 21 Oct 2021 10:50:52 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Wang ShaoBo <bobo.shaobowang@...wei.com>, akpm@...ux-foundation.org
Cc:     weiyongjun1@...wei.com, huawei.libin@...wei.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/page_alloc: use clamp() to simplify code

On 21.10.21 05:48, Wang ShaoBo wrote:
> This patch uses clamp() to simplify code in init_per_zone_wmark_min().
> 
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@...wei.com>
> ---
>  mm/page_alloc.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index b37435c274cf..d0449212a824 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -8460,16 +8460,12 @@ int __meminit init_per_zone_wmark_min(void)
>  	lowmem_kbytes = nr_free_buffer_pages() * (PAGE_SIZE >> 10);
>  	new_min_free_kbytes = int_sqrt(lowmem_kbytes * 16);
>  
> -	if (new_min_free_kbytes > user_min_free_kbytes) {
> -		min_free_kbytes = new_min_free_kbytes;
> -		if (min_free_kbytes < 128)
> -			min_free_kbytes = 128;
> -		if (min_free_kbytes > 262144)
> -			min_free_kbytes = 262144;
> -	} else {
> +	if (new_min_free_kbytes > user_min_free_kbytes)
> +		min_free_kbytes = clamp(new_min_free_kbytes, 128, 262144);
> +	else
>  		pr_warn("min_free_kbytes is not updated to %d because user defined value %d is preferred\n",
>  				new_min_free_kbytes, user_min_free_kbytes);
> -	}
> +
>  	setup_per_zone_wmarks();
>  	refresh_zone_stat_thresholds();
>  	setup_per_zone_lowmem_reserve();
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb