linux-kernel - Re: [PATCH] dmaengine: rcar-dmac: refactor the error handling code of rcar_dmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWs73KeXSrVBXS-8b0S6AXyOki+Fc_ST1SuWUQ6DD_3FA@mail.gmail.com>
Date:   Thu, 21 Oct 2021 10:57:09 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Dongliang Mu <mudongliangabcd@...il.com>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Zou Wei <zou_wei@...wei.com>,
        dmaengine <dmaengine@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: rcar-dmac: refactor the error handling code of rcar_dmac_probe

Hi Dongliang,

Thanks for your patch!

On Wed, Oct 20, 2021 at 4:36 PM Dongliang Mu <mudongliangabcd@...il.com> wrote:
> In rcar_dmac_probe, if pm_runtime_resume_and_get fails, it forgets to
> disable runtime PM. And of_dma_controller_free should only be invoked
> after the success of of_dma_controller_register.

The second issue is actually harmless, as of_dma_controller_free()
is a no-op if the DMA controller was never registered.
Of course it doesn't hurt to improve symmetry.

> Fix this by refactoring the error handling code.
>
> Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds