lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Oct 2021 20:21:47 -0400 From: Sasha Levin <sashal@...nel.org> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org Cc: Lin Ma <linma@....edu.cn>, Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>, "David S . Miller" <davem@...emloft.net>, Sasha Levin <sashal@...nel.org>, kuba@...nel.org, bongsu.jeon@...sung.com, netdev@...r.kernel.org Subject: [PATCH AUTOSEL 5.10 06/14] nfc: nci: fix the UAF of rf_conn_info object From: Lin Ma <linma@....edu.cn> [ Upstream commit 1b1499a817c90fd1ce9453a2c98d2a01cca0e775 ] The nci_core_conn_close_rsp_packet() function will release the conn_info with given conn_id. However, it needs to set the rf_conn_info to NULL to prevent other routines like nci_rf_intf_activated_ntf_packet() to trigger the UAF. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com> Signed-off-by: Lin Ma <linma@....edu.cn> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com> Signed-off-by: David S. Miller <davem@...emloft.net> Signed-off-by: Sasha Levin <sashal@...nel.org> --- net/nfc/nci/rsp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/nfc/nci/rsp.c b/net/nfc/nci/rsp.c index a48297b79f34..b0ed2b47ac43 100644 --- a/net/nfc/nci/rsp.c +++ b/net/nfc/nci/rsp.c @@ -277,6 +277,8 @@ static void nci_core_conn_close_rsp_packet(struct nci_dev *ndev, ndev->cur_conn_id); if (conn_info) { list_del(&conn_info->list); + if (conn_info == ndev->rf_conn_info) + ndev->rf_conn_info = NULL; devm_kfree(&ndev->nfc_dev->dev, conn_info); } } -- 2.33.0
Powered by blists - more mailing lists