linux-kernel - Re: [PATCH v3 00/10] regulator/mfd/clock: dt-bindings: Samsung S2M and S5M to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4be10d9d-fbe5-3dd6-be0a-2b66a857a015@canonical.com>
Date:   Thu, 21 Oct 2021 11:14:56 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Tomasz Figa <tomasz.figa@...il.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v3 00/10] regulator/mfd/clock: dt-bindings: Samsung S2M
 and S5M to dtschema

On 21/10/2021 11:07, Lee Jones wrote:
> On Wed, 20 Oct 2021, Krzysztof Kozlowski wrote:
> 
>> On 20/10/2021 18:08, Krzysztof Kozlowski wrote:
>>> On 20/10/2021 18:04, Lee Jones wrote:
>>>> On Wed, 06 Oct 2021, Krzysztof Kozlowski wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> Changes since v2
>>>>> ================
>>>>> 1. Add Rob's tags.
>>>>> 2. Remove "regulator-name" from properties (all regulator dtschema).
>>>>> 3. Move "unevaluatedProperties" higher to make code easier to read (all regulator dtschema).
>>>>> 4. Add ref-type to op-mode property (patch 6: s5m8767 regulators).
>>>>>
>>>>> Changes since v1
>>>>> ================
>>>>> 1. Drop DTS patches - applied.
>>>>> 2. Fully remove bindings/regulator/samsung,s5m8767.txt .
>>>>> 3. Minor subject reformatting and few typos in text.
>>>>>
>>>>>
>>>>> Intro
>>>>> =====
>>>>> This patchset converts all devicetree bindings of Samsung S2M and S5M
>>>>> PMIC devices from txt to dtschema.
>>>>>
>>>>> It includes also two fixes because later conversion depends on it
>>>>> (contextually).
>>>>>
>>>>>
>>>>> Merging/dependencies
>>>>> ====================
>>>>> 1. Regulator related binding changes depend on first two commits (the
>>>>>    fixes), because of context.
>>>>> 2. The mfd bindings depend on clock and regulator bindings.
>>>>>
>>>>> The fixes and bindings changes (patches 1-10) should go via the same
>>>>> tree.  For example regulator or mfd tree.
>>>>>
>>>>> Another alternative is that regulator patches (1-2, 4-6) go via Mark who
>>>>> later gives MFD a stable branch/tag to pull. Then the clock and MFD
>>>>> bindings would go on top via MFD tree. Or any other setup you would like
>>>>> to have. :)
>>>>>
>>>>>
>>>>> Overview of devices
>>>>> ===================
>>>>> Essentially all Samsung S2M and S5M PMICs are very similar devices. They
>>>>> provide the same functionality: regulators, RTC, 2 or 3 clocks and main
>>>>> power management (e.g. power cut to SoC).
>>>>>
>>>>> The differences are mostly in registers layout and number of regulators.
>>>>>
>>>>> The drivers are built around one common part, mfd/sec-core.c, and share
>>>>> some drivers between devices:
>>>>> 1. MFD sec-core for all devices,
>>>>> 1. one clock driver for most of devices,
>>>>> 2. one RTC driver for all devices,
>>>>> 3. three regulator drivers.
>>>>>
>>>>> The regulator drivers were implementing slightly different features,
>>>>> therefore one regulator binding for all devices does not make much
>>>>> sense.  However the clock device binding can be shared.
>>>>>
>>>>> The final dtschema bindings try to implement this - share only the clock
>>>>> bindings.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>>> Krzysztof Kozlowski (10):
>>>>>   regulator: s5m8767: do not use reset value as DVS voltage if GPIO DVS
>>>>>     is disabled
>>>>>   regulator: dt-bindings: samsung,s5m8767: correct
>>>>>     s5m8767,pmic-buck-default-dvs-idx property
>>>>>   dt-bindings: clock: samsung,s2mps11: convert to dtschema
>>>>>   regulator: dt-bindings: samsung,s2m: convert to dtschema
>>>>>   regulator: dt-bindings: samsung,s2mpa01: convert to dtschema
>>>>>   regulator: dt-bindings: samsung,s5m8767: convert to dtschema
>>>>>   dt-bindings: mfd: samsung,s2mps11: convert to dtschema
>>>>>   dt-bindings: mfd: samsung,s2mpa01: convert to dtschema
>>>>>   dt-bindings: mfd: samsung,s5m8767: convert to dtschema
>>>>>   dt-bindings: mfd: samsung,s5m8767: document buck and LDO supplies
>>>>
>>>> Looks like these are ready to be pushed.
>>>>
>>>> However, I am not in receipt of patches 1-2.
>>>>
>>>> Am I okay to merge 3-10 right now?
>>>
>>> No. This is v3, but we need v4. Please:
>>> 1. Merge tag from Mark:
>>> https://lore.kernel.org/lkml/YWCT+YL%2F9qHbF9f0@sirena.org.uk/
>>>
>>> 2. Then apply patches 7-10 (MFD bindings).
>>
>> ... patches 7-10 from that v4 of course. They start here:
>> https://lore.kernel.org/lkml/20211008113931.134847-4-krzysztof.kozlowski@canonical.com/
> 
> ... and these can do in on their own?  With no inter-dependencies?
> 
> Or is Rob going to tell me off again?

The 7-10 depend on 1-6 from this set. 1-6 are in the tag provided by
Mark, so you have to base your work on Mark's tag.

Then you will get everything from this patchset (but v4, not v3 please).
The patchset itself does not depend on anything else, so I do not expect
Rob objecting. It was also reviewed by Rob.

To summarize: please merge tag from Mark and apply patches 7-10 from v4
on top of that tag.


Best regards,
Krzysztof