linux-kernel - Re: [PATCH] [RFC] RDMA/mlx5: fix build error with INFINIBAND_USER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YXExkx2jieJwe71d@unreal>
Date:   Thu, 21 Oct 2021 12:23:31 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Mark Zhang <markzhang@...dia.com>,
        Aharon Landau <aharonl@...dia.com>,
        Arnd Bergmann <arnd@...db.de>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>, Mark Bloch <mbloch@...dia.com>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC] RDMA/mlx5: fix build error with
 INFINIBAND_USER_ACCESS=n

On Tue, Oct 19, 2021 at 08:15:45AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The mlx5_ib_fs_add_op_fc/mlx5_ib_fs_remove_op_fc functions are
> only available when user access is enabled, without that we
> run into a link error:
> 
> ERROR: modpost: "mlx5_ib_fs_add_op_fc" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!
> ERROR: modpost: "mlx5_ib_fs_remove_op_fc" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!
> 
> Conditionally compiling the newly added code section makes
> it build, though this is probably not a correct fix.
> 
> Fixes: a29b934ceb4c ("RDMA/mlx5: Add modify_op_stat() support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/infiniband/hw/mlx5/counters.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 

Thanks,
Acked-by: Leon Romanovsky <leonro@...dia.com>