linux-kernel - Re: [PATCH] mfd: replace snprintf in show functions with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Oct 2021 12:16:49 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Qing Wang <wangqing@...o.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: replace snprintf in show functions with sysfs_emit

On Thu, 14 Oct 2021, Qing Wang wrote:

> show() must not use snprintf() when formatting the value to be
> returned to user space.
> 
> Fix the following coccicheck warning:
> drivers/mfd/janz-cmodio.c:157: WARNING: use scnprintf or sprintf.
> 
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> 
> Signed-off-by: Qing Wang <wangqing@...o.com>
> ---
>  drivers/mfd/janz-cmodio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I've fixed the subject line for you and applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog