linux-kernel - RE: [Intel-wired-lan] [PATCH] ice: Fix clang -Wimplicit-fallthrough in ice_pull_qvec_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Oct 2021 11:45:16 +0000
From:   "G, GurucharanX" <gurucharanx.g@...el.com>
To:     Nathan Chancellor <nathan@...nel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH] ice: Fix clang -Wimplicit-fallthrough
 in ice_pull_qvec_from_rc()



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Nathan Chancellor
> Sent: Tuesday, October 19, 2021 7:12 AM
> To: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; David S. Miller <davem@...emloft.net>; Jakub
> Kicinski <kuba@...nel.org>
> Cc: netdev@...r.kernel.org; llvm@...ts.linux.dev; Nick Desaulniers
> <ndesaulniers@...gle.com>; linux-kernel@...r.kernel.org; Nathan Chancellor
> <nathan@...nel.org>; intel-wired-lan@...ts.osuosl.org
> Subject: [Intel-wired-lan] [PATCH] ice: Fix clang -Wimplicit-fallthrough in
> ice_pull_qvec_from_rc()
> 
> Clang warns:
> 
> drivers/net/ethernet/intel/ice/ice_lib.c:1906:2: error: unannotated fall-through
> between switch labels [-Werror,-Wimplicit-fallthrough]
>         default:
>         ^
> drivers/net/ethernet/intel/ice/ice_lib.c:1906:2: note: insert 'break;' to avoid
> fall-through
>         default:
>         ^
>         break;
> 1 error generated.
> 
> Clang is a little more pedantic than GCC, which does not warn when falling
> through to a case that is just break or return. Clang's version is more in line
> with the kernel's own stance in deprecated.rst, which states that all switch/case
> blocks must end in either break, fallthrough, continue, goto, or return. Add the
> missing break to silence the warning.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/1482
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Tested-by: Gurucharan G <gurucharanx.g@...el.com> (A Contingent worker at Intel)