linux-kernel - Re: [PATCH] clocksource/drivers: depend on sub-architecture for Exynos MCT and Samsung PWM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc0e9d34-72f6-0d95-fa4f-a25f5d8e5125@linaro.org>
Date:   Thu, 21 Oct 2021 14:07:45 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers: depend on sub-architecture for
 Exynos MCT and Samsung PWM

On 21/10/2021 08:35, Krzysztof Kozlowski wrote:
> The Exynos MCT and Samsung PWM Timer clocksource drivers are not usable
> on anything else than Samsung Exynos, S3C or S5P SoC platforms.  These
> are integral parts of a SoC.  Even though the drivers are not user
> selectable, still document the hardware architecture explicitly with
> depends on ARCH_EXYNOS and others.  This also serves a purpose of
> documenting use-case, if someone ever wonders whether to select the
> driver for his platform.  No functional change, because drivers are
> already selected by the platform described in depends. We follow similar
> approach also for other SoC-specific drivers.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
>  drivers/clocksource/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 0f5e3983951a..3ff6e1f87246 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -418,12 +418,14 @@ config ATMEL_TCB_CLKSRC
>  config CLKSRC_EXYNOS_MCT
>  	bool "Exynos multi core timer driver" if COMPILE_TEST
>  	depends on ARM || ARM64
> +	depends on ARCH_EXYNOS || COMPILE_TEST
>  	help
>  	  Support for Multi Core Timer controller on Exynos SoCs.
>  
>  config CLKSRC_SAMSUNG_PWM
>  	bool "PWM timer driver for Samsung S3C, S5P" if COMPILE_TEST
>  	depends on HAS_IOMEM
> +	depends on ARCH_EXYNOS || ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210 || COMPILE_TEST
>  	help
>  	  This is a new clocksource driver for the PWM timer found in
>  	  Samsung S3C, S5P and Exynos SoCs, replacing an earlier driver
> 

Applied, thanks

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog