linux-kernel - RE: [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Oct 2021 12:16:09 +0000
From:   quic_sbillaka <quic_sbillaka@...cinc.com>
To:     Doug Anderson <dianders@...omium.org>,
        quic_sbillaka <quic_sbillaka@...cinc.com>
CC:     dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        freedreno <freedreno@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Sankeerth Billakanti <sbillaka@...eaurora.org>,
        Rob Clark <robdclark@...il.com>,
        Sean Paul <seanpaul@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Kalyan Thota <kalyan_t@...eaurora.org>,
        Abhinav Kumar <abhinavk@...eaurora.org>,
        Kuogee Hsieh <khsieh@...eaurora.org>,
        Krishna Manikandan <mkrishn@...eaurora.org>
Subject: RE: [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string

Hi Doug,

Sorry about that, this is the first time I am posting changes upstream and still getting hold of conventions.

I think I misinterpreted your subject line comment and changed the just title to include dp-controller. I will correct it in the next version.

sc7280-dp will be added later when dp support for sc7280 will be posted. I will reply on the feedback email from Stephen.

Thank you,
Sankeerth

-----Original Message-----
From: Doug Anderson <dianders@...omium.org> 
Sent: Wednesday, October 20, 2021 11:11 PM
To: quic_sbillaka <quic_sbillaka@...cinc.com>
Cc: dri-devel <dri-devel@...ts.freedesktop.org>; linux-arm-msm <linux-arm-msm@...r.kernel.org>; freedreno <freedreno@...ts.freedesktop.org>; LKML <linux-kernel@...r.kernel.org>; Sankeerth Billakanti <sbillaka@...eaurora.org>; Rob Clark <robdclark@...il.com>; Sean Paul <seanpaul@...omium.org>; Stephen Boyd <swboyd@...omium.org>; Kalyan Thota <kalyan_t@...eaurora.org>; Abhinav Kumar <abhinavk@...eaurora.org>; Kuogee Hsieh <khsieh@...eaurora.org>; Krishna Manikandan <mkrishn@...eaurora.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

Hi,

On Wed, Oct 20, 2021 at 5:14 AM Sankeerth Billakanti <quic_sbillaka@...cinc.com> wrote:
>
> From: Sankeerth Billakanti <sbillaka@...eaurora.org>
>
> The Qualcomm SC7280 platform supports an eDP controller, add 
> compatible string for it to dp-controller.
>
> Signed-off-by: Sankeerth Billakanti <quic_sbillaka@...cinc.com>
> ---
>  Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 
> +
>  1 file changed, 1 insertion(+)

I think you ignored some of the feedback that was given on v1. Perhaps you could go back and re-read that feedback? See the replies to:

https://lore.kernel.org/r/1628726882-27841-3-git-send-email-sbillaka@codeaurora.org/

For one, ${SUBJECT} needs updating. It's probably as simple as adding the "msm/dp" tag, like:

dt-bindings: msm/dp: Add SC7280 compatible string

For another, Stephen requested that you add "sc7280-dp" too.