linux-kernel - Re: Non-existing config symbols DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Oct 2021 15:58:56 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Russell King <linux@...linux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-omap@...r.kernel.org
Subject: Re: Non-existing config symbols DEBUG_OMAP{3,4,5}UART{1,2}

Hi,

* Lukas Bulwahn <lukas.bulwahn@...il.com> [211011 05:39]:
> Dear Tony,
> 
> With commit d2b310b0234c ("ARM: debug: Use generic 8250 debug_ll for
> omap2 and omap3/4/5 common uarts"), you added address definitions of
> DEBUG_UART_PHYS for OMAP2, OMAP3, OMAP4 and OMAP5 in
> ./arch/arm/Kconfig.debug.
> 
> These definitions depend on:
>   - DEBUG_OMAP2UART1 || DEBUG_OMAP3UART1 || DEBUG_OMAP4UART1 ||
> DEBUG_OMAP5UART1, and
>   - DEBUG_OMAP2UART2 || DEBUG_OMAP3UART2 || DEBUG_OMAP4UART2 ||
> DEBUG_OMAP5UART2.
> 
> As of now, only DEBUG_OMAP2UART{1,2} are defined in
> ./arch/arm/Kconfig.debug, but DEBUG_OMAP{3,4,5}UART{1,2} are not
> defined. Hence, ./scripts/checkkconfigsymbols.py warns here on
> non-existing symbols.
> 
> I am unsure about the best way to resolve this issue.
> 
> - Would you like to simply reuse the config DEBUG_OMAP2UART{1,2} also
> for OMAP3, OMAP4 and OMAP5? Then, we probably just need to delete the
> dead references
> to DEBUG_OMAP{3,4,5}UART{1,2}. If you consider this further change
> helpful, we could even rename the configs to DEBUG_OMAP2PLUSUART{1,2}
> to make the architecture more specific.
> 
> - Do you see the need for separate config definitions for UART{1,2} on
> OMAP3, OMAP4 and OMAP5? Then, we would need to add further definitions
> DEBUG_OMAP{3,4,5}UART{1,2}
> in this file and link those to the specific architecture.
> 
> Once the direction is clear, I am happy to provide a patch to address
> this issue or you can quickly take care of this yourself.

The missing ones should be the same as the DEBUG_OMAP2 I think. We still
have these defined in arch/arm/mach-omap2/include/mach/serial.h, so that
can be used to confirm it.

Seems like we can just reuse the DEBUG_OMAP2UART variants, not sure if
we need to rename these to DEBUG_OMAP2PLUSUART variants.

Regards,

Tony