linux-kernel - Re: [PATCH 0/2] nbd: fix sanity check for first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17182476-e5bf-f493-9d9b-fedb2d9c8e1a@huawei.com>
Date:   Thu, 21 Oct 2021 21:13:11 +0800
From:   "yukuai (C)" <yukuai3@...wei.com>
To:     Pavel Skripkin <paskripkin@...il.com>, <josef@...icpanda.com>,
        <axboe@...nel.dk>
CC:     <linux-block@...r.kernel.org>, <nbd@...er.debian.org>,
        <linux-kernel@...r.kernel.org>, <yi.zhang@...wei.com>,
        <luomeng12@...wei.com>, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 0/2] nbd: fix sanity check for first_minor

On 2021/10/21 20:35, Pavel Skripkin wrote:
> On 10/21/21 15:29, Yu Kuai wrote:
>> Yu Kuai (2):
>>    nbd: fix max value for 'first_minor'
>>    nbd: fix possible overflow for 'first_minor' in nbd_dev_add()
>>
>>   drivers/block/nbd.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
> 
> Hi, Yu!
> 
> Thank you for the fix, but this wrong check should be just removed, 
> since root case of wrong sysfs file creation was fixed, as Christoph 
> said [1]

Hi, Pavel

Thanks for your response, with the root cause fixed, patch 1 is not
needed anymore. However, the overflow case in patch 2 is still
possible.

Does anyone plan to remove the checking?

Thanks,
Kuai
> 
> 
> 
> 
> [1] https://lore.kernel.org/lkml/20211011073556.GA10735@lst.de/
> 
> 
> 
> With regards,
> Pavel Skripkin
> .
>