linux-kernel - Re: [PATCH 21/20] signal: Replace force_sigsegv(SIGSEGV) with force_fatal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tuhaijsw.fsf@disp2133>
Date:   Thu, 21 Oct 2021 08:33:51 -0500
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rich Felker <dalias@...c.org>,
        "open list\:TENSILICA XTENSA PORT \(xtensa\)" 
        <linux-xtensa@...ux-xtensa.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        "open list\:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
        Max Filippov <jcmvbkbc@...il.com>,
        Paul Mackerras <paulus@...ba.org>,
        H Peter Anvin <hpa@...or.com>,
        sparclinux <sparclinux@...r.kernel.org>,
        Vincent Chen <deanbo422@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        linux-s390 <linux-s390@...r.kernel.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Michael Ellerman <mpe@...erman.id.au>,
        Linux-sh list <linux-sh@...r.kernel.org>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Ingo Molnar <mingo@...hat.com>,
        Jonas Bonn <jonas@...thpole.se>,
        Kees Cook <keescook@...omium.org>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Openrisc <openrisc@...ts.librecores.org>,
        Borislav Petkov <bp@...en8.de>,
        Al Viro <viro@...iv.linux.org.uk>,
        Andy Lutomirski <luto@...nel.org>,
        Chris Zankel <chris@...kel.net>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Nick Hu <nickhu@...estech.com>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Maciej Rozycki <macro@...am.me.uk>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        David Miller <davem@...emloft.net>,
        Greentime Hu <green.hu@...il.com>
Subject: Re: [PATCH 21/20] signal: Replace force_sigsegv(SIGSEGV) with force_fatal_sig(SIGSEGV)

Geert Uytterhoeven <geert@...ux-m68k.org> writes:

> Hi Eric,
>
> Patch 21/20?

In reviewing another part of the patchset Linus asked if force_sigsegv
could go away.  It can't completely but I can get this far.

Given that it is just a cleanup it makes most sense to me as an
additional patch on top of what is already here.


> On Wed, Oct 20, 2021 at 11:52 PM Eric W. Biederman
> <ebiederm@...ssion.com> wrote:
>> Now that force_fatal_sig exists it is unnecessary and a bit confusing
>> to use force_sigsegv in cases where the simpler force_fatal_sig is
>> wanted.  So change every instance we can to make the code clearer.
>>
>> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
>
>>  arch/m68k/kernel/traps.c        | 2 +-
>
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Thank you.

Eric