linux-kernel - Re: [PATCH 1/6] kthread: Add the helper macro kthread_run_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211021135312.GA3400@LAPTOP-UKSR4ENP.internal.baidu.com>
Date:   Thu, 21 Oct 2021 21:53:12 +0800
From:   Cai Huoqing <caihuoqing@...du.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     Bernard Metzler <bmt@...ich.ibm.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Davidlohr Bueso <dave@...olabs.net>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Josh Triplett <josh@...htriplett.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        "Ingo Molnar" <mingo@...hat.com>,
        Daniel Bristot de Oliveira <bristot@...nel.org>,
        <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <rcu@...r.kernel.org>
Subject: Re: [PATCH 1/6] kthread: Add the helper macro kthread_run_on_cpu()

On 21 10月 21 09:10:01, Steven Rostedt wrote:
> On Thu, 21 Oct 2021 20:01:30 +0800
> Cai Huoqing <caihuoqing@...du.com> wrote:
> 
> > the helper macro kthread_run_on_cpu() inculdes
> 
>  "includes"
> 
> > kthread_create_on_cpu/wake_up_process().
> > In some cases, use kthread_run_on_cpu() directly instead of
> > kthread_create_on_node/kthread_bind/wake_up_process() or
> > kthread_create_on_cpu/wake_up_process() or
> > kthreadd_create/kthread_bind/wake_up_process() to simplify the code.
> > 
> > Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> > ---
> >  include/linux/kthread.h | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/include/linux/kthread.h b/include/linux/kthread.h
> > index 346b0f269161..dfd125523aa9 100644
> > --- a/include/linux/kthread.h
> > +++ b/include/linux/kthread.h
> > @@ -56,6 +56,28 @@ bool kthread_is_per_cpu(struct task_struct *k);
> >  	__k;								   \
> >  })
> >  
> > +/**
> > + * kthread_run_on_cpu - create and wake a cpu bound thread.
> > + * @threadfn: the function to run until signal_pending(current).
> > + * @data: data ptr for @threadfn.
> > + * @cpu: The cpu on which the thread should be bound,
> > + * @namefmt: printf-style name for the thread. Format is restricted
> > + *	     to "name.*%u". Code fills in cpu number.
> > + *
> > + * Description: Convenient wrapper for kthread_create_on_node()
> > + * followed by wake_up_process().  Returns the kthread or
> > + * ERR_PTR(-ENOMEM).
> > + */
> > +#define kthread_run_on_cpu(threadfn, data, cpu, namefmt)		  \
> 
> Why is this a macro and not a static inline function?
> 
> -- Steve
Hi,Thanks for your feedback,

I think using static inline function is nice, but here try to keep
consistent with the other macros,
sush as kthread_create/kthread_init_work...

Thanks,
Cai.
> 
> > +({									  \
> > +	struct task_struct *__k						  \
> > +		= kthread_create_on_cpu(threadfn, data, cpu_to_node(cpu), \
> > +					namefmt);			  \
> > +	if (!IS_ERR(__k))						  \
> > +		wake_up_process(__k);					  \
> > +	__k;								  \
> > +})
> > +
> >  void free_kthread_struct(struct task_struct *k);
> >  void kthread_bind(struct task_struct *k, unsigned int cpu);
> >  void kthread_bind_mask(struct task_struct *k, const struct cpumask *mask);
>