linux-kernel - Re: [PATCH 04/18] dt-bindings: mtd: spi-nand: Convert spi-nand description file to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211021160932.4169f66f@xps13>
Date:   Thu, 21 Oct 2021 16:09:32 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Tudor Ambarus <Tudor.Ambarus@...rochip.com>,
        linux-mtd@...ts.infradead.org, Julien Su <juliensu@...c.com.tw>,
        linux-spi@...r.kernel.org, Jaime Liao <jaimeliao@...c.com.tw>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Boris Brezillon <boris.brezillon@...labora.com>,
        Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
        Xiangsheng Hou <Xiangsheng.Hou@...iatek.com>,
        Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/18] dt-bindings: mtd: spi-nand: Convert spi-nand
 description file to yaml

Hi Rob,

robh@...nel.org wrote on Wed, 20 Oct 2021 16:14:47 -0500:

> On Wed, 20 Oct 2021 16:27:55 +0200, Miquel Raynal wrote:
> > Let's get rid of spi-nand.txt by converting it to yaml schema. While at
> > converting this file, let's actually pull all the generic properties
> > from nand-chip.yaml which might apply to a SPI-NAND chip.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> > ---
> >  .../devicetree/bindings/mtd/spi-nand.txt      |  5 ----
> >  .../devicetree/bindings/mtd/spi-nand.yaml     | 27 +++++++++++++++++++
> >  2 files changed, 27 insertions(+), 5 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.txt
> >  create mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.yaml
> >   
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/mtd/nand-chip.yaml'
> xargs: dt-doc-validate: exited with status 255; aborting
> make[1]: *** Deleting file 'Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.example.dt.yaml'
> Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/mtd/nand-chip.yaml'
> make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.example.dt.yaml] Error 255
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1441: dt_binding_check] Error 2

I am not able to reproduce this error and in general I don't understand
it. There is no relationship between this change and
snps,dw-apb-ssi.yaml. Also the fact that nand-chip-yaml do not exist,
it was just created in the patch before so I wonder how much I should
trust this error.

Also, maybe I am not using the tools properly, but it is very hard to
send correct bindings at the first try. Running make dt_binding_check
takes ages, any change in one yaml file will recheck the entire data
base and filtering out on a single yaml file is generally too
restrictive and still prints unrelated errors of syntax on other files.
I don't know how much of this is actually expected and/or if someone is
working on it.

Thanks,
Miquèl