linux-kernel - Re: Re: [PATCH 0/6] kthread: Add the helper macro kthread_run_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OFA768FC6A.4B984E4E-ON00258775.004E3F00-00258775.004E3F06@ibm.com>
Date:   Thu, 21 Oct 2021 14:14:39 +0000
From:   "Bernard Metzler" <BMT@...ich.ibm.com>
To:     "Cai Huoqing" <caihuoqing@...du.com>
Cc:     "Doug Ledford" <dledford@...hat.com>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        "Davidlohr Bueso" <dave@...olabs.net>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        "Josh Triplett" <josh@...htriplett.org>,
        "Steven Rostedt" <rostedt@...dmis.org>,
        "Mathieu Desnoyers" <mathieu.desnoyers@...icios.com>,
        "Lai Jiangshan" <jiangshanlai@...il.com>,
        "Joel Fernandes" <joel@...lfernandes.org>,
        "Ingo Molnar" <mingo@...hat.com>,
        "Daniel Bristot de Oliveira" <bristot@...nel.org>,
        <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <rcu@...r.kernel.org>
Subject: Re: Re: [PATCH 0/6] kthread: Add the helper macro kthread_run_on_cpu()

-----"Cai Huoqing" <caihuoqing@...du.com> wrote: -----

>To: "Bernard Metzler" <BMT@...ich.ibm.com>
>From: "Cai Huoqing" <caihuoqing@...du.com>
>Date: 10/21/2021 04:08PM
>Cc: "Doug Ledford" <dledford@...hat.com>, "Jason Gunthorpe"
><jgg@...pe.ca>, "Davidlohr Bueso" <dave@...olabs.net>, "Paul E.
>McKenney" <paulmck@...nel.org>, "Josh Triplett"
><josh@...htriplett.org>, "Steven Rostedt" <rostedt@...dmis.org>,
>"Mathieu Desnoyers" <mathieu.desnoyers@...icios.com>, "Lai Jiangshan"
><jiangshanlai@...il.com>, "Joel Fernandes" <joel@...lfernandes.org>,
>"Ingo Molnar" <mingo@...hat.com>, "Daniel Bristot de Oliveira"
><bristot@...nel.org>, <linux-rdma@...r.kernel.org>,
><linux-kernel@...r.kernel.org>, <rcu@...r.kernel.org>
>Subject: [EXTERNAL] Re: [PATCH 0/6] kthread: Add the helper macro
>kthread_run_on_cpu()
>
>On 21 10月 21 13:48:15, Bernard Metzler wrote:
>> -----"Cai Huoqing" <caihuoqing@...du.com> wrote: -----
>> 
>> >To: <caihuoqing@...du.com>
>> >From: "Cai Huoqing" <caihuoqing@...du.com>
>> >Date: 10/21/2021 02:02PM
>> >Cc: "Bernard Metzler" <bmt@...ich.ibm.com>, "Doug Ledford"
>> ><dledford@...hat.com>, "Jason Gunthorpe" <jgg@...pe.ca>,
>"Davidlohr
>> >Bueso" <dave@...olabs.net>, "Paul E. McKenney"
><paulmck@...nel.org>,
>> >"Josh Triplett" <josh@...htriplett.org>, "Steven Rostedt"
>> ><rostedt@...dmis.org>, "Mathieu Desnoyers"
>> ><mathieu.desnoyers@...icios.com>, "Lai Jiangshan"
>> ><jiangshanlai@...il.com>, "Joel Fernandes"
><joel@...lfernandes.org>,
>> >"Ingo Molnar" <mingo@...hat.com>, "Daniel Bristot de Oliveira"
>> ><bristot@...nel.org>, <linux-rdma@...r.kernel.org>,
>> ><linux-kernel@...r.kernel.org>, <rcu@...r.kernel.org>
>> >Subject: [EXTERNAL] [PATCH 0/6] kthread: Add the helper macro
>> >kthread_run_on_cpu()
>> >
>> >the helper macro kthread_run_on_cpu() inculdes
>> >kthread_create_on_cpu/wake_up_process().
>> >In some cases, use kthread_run_on_cpu() directly instead of
>> >kthread_create_on_node/kthread_bind/wake_up_process() or
>> >kthread_create_on_cpu/wake_up_process() or
>> >kthreadd_create/kthread_bind/wake_up_process() to simplify the
>code.
>> 
>> I do not see kthread_bind() being covered by the helper,
>> as claimed? rcutorture, ring-buffer, siw are using it in
>> the code potentially being replaced by the helper.
>> kthread_bind() is best to be called before thread starts
>> running, so should be part of it.
>Hi,
>kthread_bind() is already part of kthread_create_on_cpu which is
>called by kthread_run_on_cpu() here.
>

Indeed! Thanks, Bernard.

>Thanks,
>Cai.
>> 
>> Thanks,
>> Bernard.
>> >
>> >Cai Huoqing (6):
>> >  kthread: Add the helper macro kthread_run_on_cpu()
>> >  RDMA/siw: Make use of the helper macro kthread_run_on_cpu()
>> >  ring-buffer: Make use of the helper macro kthread_run_on_cpu()
>> >  rcutorture: Make use of the helper macro kthread_run_on_cpu()
>> >  trace/osnoise: Make use of the helper macro kthread_run_on_cpu()
>> >  trace/hwlat: Make use of the helper macro kthread_run_on_cpu()
>> >
>> > drivers/infiniband/sw/siw/siw_main.c |  7 +++----
>> > include/linux/kthread.h              | 22 ++++++++++++++++++++++
>> > kernel/rcu/rcutorture.c              |  7 ++-----
>> > kernel/trace/ring_buffer.c           |  7 ++-----
>> > kernel/trace/trace_hwlat.c           |  6 +-----
>> > kernel/trace/trace_osnoise.c         |  3 +--
>> > 6 files changed, 31 insertions(+), 21 deletions(-)
>> >
>> >-- 
>> >2.25.1
>> >
>> >
>