linux-kernel - Re: [PATCH v1] regulator: Don't error out fixed regulator in regulator_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Oct 2021 15:33:37 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Thierry Reding <treding@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH v1] regulator: Don't error out fixed regulator in
 regulator_sync_voltage()

On Thu, Oct 21, 2021 at 04:55:17PM +0300, Dmitry Osipenko wrote:

> The alternative could be to check regulator's capabilities:

> if (!regulator_ops_is_valid(rdev, REGULATOR_CHANGE_VOLTAGE))
> 	return 0;

> This looks like a better variant, actually.

Yes, that should be more robust.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)