lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 22 Oct 2021 21:54:40 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Li Yang <leoyang.li@....com>
Cc:     arm-soc <arm@...nel.org>, SoC Team <soc@...nel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Diana Craciun <diana.craciun@....com>
Subject: Re: [GIT PULL] soc/fsl drivers changes for fix(v5.15)

On Fri, Oct 22, 2021 at 3:00 AM Li Yang <leoyang.li@....com> wrote:
> ----------------------------------------------------------------
> NXP/FSL SoC driver fixes for v5.15

> - fix qbman alignment error in the virtualization context

This patch looks very suspicious to me, I don't think it's generally safe to
use memcpy_toio() on a normal pointer, as the __iomem tokens may
be in a separate address range, even though this currently works
on arm64. Adding the  (__iomem void *) cast without a comment that
explains why it's added seems similarly wrong, and finally the
changeset text does not seem to match what the code does:

According to the text, the pointer is to a virtual address mapped as
"device memory" (i.e. PROT_DEVICE_nGnRE or PROT_DEVICE_nGnRnE),
but the code suggests it's actually write-combining normal
(PROT_NORMAL_NC).

I don't see any discussion of this patch on the mailing list either, so
please resend the pull request without this patch, while we try to figure
out what the driver should actually be doing here.

       Arnd

Powered by blists - more mailing lists