linux-kernel - Re: [PATCH 1/4] hugetlb_cgroup: Remove unused hugetlb_cgroup_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d99cedb7-1711-dc16-852e-df6ea9f450da@oracle.com>
Date:   Fri, 22 Oct 2021 13:16:56 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>,
        akpm@...ux-foundation.org
Cc:     mhocko@...nel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] hugetlb_cgroup: Remove unused
 hugetlb_cgroup_from_counter macro

On 10/20/21 11:31 PM, Baolin Wang wrote:
> Since commit 726b7bbe ("hugetlb_cgroup: fix illegal access to memory"),
> the hugetlb_cgroup_from_counter() macro is not used any more, remove it.
> 
> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> ---
>  mm/hugetlb_cgroup.c | 3 ---
>  1 file changed, 3 deletions(-)

Thanks!

Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>
-- 
Mike Kravetz

> 
> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> index 5383023..79d9353 100644
> --- a/mm/hugetlb_cgroup.c
> +++ b/mm/hugetlb_cgroup.c
> @@ -27,9 +27,6 @@
>  #define MEMFILE_IDX(val)	(((val) >> 16) & 0xffff)
>  #define MEMFILE_ATTR(val)	((val) & 0xffff)
>  
> -#define hugetlb_cgroup_from_counter(counter, idx)                   \
> -	container_of(counter, struct hugetlb_cgroup, hugepage[idx])
> -
>  static struct hugetlb_cgroup *root_h_cgroup __read_mostly;
>  
>  static inline struct page_counter *
>