linux-kernel - Re: [PATCH 3/4] hugetlb: Remove redundant validation in has_same_uncharge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db6aaee8-f020-c93b-1c96-de9fcdc57e2d@oracle.com>
Date:   Fri, 22 Oct 2021 14:04:23 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>,
        akpm@...ux-foundation.org
Cc:     mhocko@...nel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] hugetlb: Remove redundant validation in
 has_same_uncharge_info()

On 10/20/21 11:31 PM, Baolin Wang wrote:
> The callers of has_same_uncharge_info() has accessed the original file_region
> and new file_region, and they are impossible to be NULL now. So we can remove
> the file_region validation in has_same_uncharge_info() to simplify the code.
> 
> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> ---
>  mm/hugetlb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks!

Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>

-- 
Mike Kravetz

> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 8902b07..5922629 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -333,8 +333,7 @@ static bool has_same_uncharge_info(struct file_region *rg,
>  				   struct file_region *org)
>  {
>  #ifdef CONFIG_CGROUP_HUGETLB
> -	return rg && org &&
> -	       rg->reservation_counter == org->reservation_counter &&
> +	return rg->reservation_counter == org->reservation_counter &&
>  	       rg->css == org->css;
>  
>  #else
>