linux-kernel - Re: [PATCH net-next v3] net: marvell: prestera: add firmware v4.0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Oct 2021 22:10:52 +0000
From:   "Volodymyr Mytnyk [C]" <vmytnyk@...vell.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        Mickey Rachamim <mickeyr@...vell.com>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        "Vadym Kochan [C]" <vkochan@...vell.com>,
        Yevhen Orlov <yevhen.orlov@...ision.eu>,
        "Taras Chornyi [C]" <tchornyi@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3] net: marvell: prestera: add firmware v4.0
 support

> On Fri, Oct 22, 2021 at 02:27:37PM +0200, Andrew Lunn wrote:
> > On Wed, Oct 20, 2021 at 12:32:28PM +0300, Volodymyr Mytnyk wrote:
> > > From: Volodymyr Mytnyk <vmytnyk@...vell.com>
> > > 
> > > Add firmware (FW) version 4.0 support for Marvell Prestera
> > > driver.
> > > 
> > > Major changes have been made to new v4.0 FW ABI to add support
> > > of new features, introduce the stability of the FW ABI and ensure
> > > better forward compatibility for the future driver vesrions.
> > > 
> > > Current v4.0 FW feature set support does not expect any changes
> > > to ABI, as it was defined and tested through long period of time.
> > > The ABI may be extended in case of new features, but it will not
> > > break the backward compatibility.
> > > 
> > > ABI major changes done in v4.0:
> > > - L1 ABI, where MAC and PHY API configuration are split.
> > > - ACL has been split to low-level TCAM and Counters ABI
> > >   to provide more HW ACL capabilities for future driver
> > >   versions.
> > > 
> > > To support backward support, the addition compatibility layer is
> > > required in the driver which will have two different codebase under
> > > "if FW-VER elif FW-VER else" conditions that will be removed
> > > in the future anyway, So, the idea was to break backward support
> > > and focus on more stable FW instead of supporting old version
> > > with very minimal and limited set of features/capabilities.
> >  
> > > +/* TODO: add another parameters here: modes, etc... */
> > > +struct prestera_port_phy_config {
> > > +   bool admin;
> > > +   u32 mode;
> > > +   u8 mdix;
> > > +};
> > 
> > > @@ -242,10 +246,44 @@ union prestera_msg_port_param {
> > >      u8  duplex;
> > >      u8  fec;
> > >      u8  fc;
> > > -   struct prestera_msg_port_mdix_param mdix;
> > > -   struct prestera_msg_port_autoneg_param autoneg;
> > > +
> > > +   union {
> > > +           struct {
> > > +                   /* TODO: merge it with "mode" */
> > 
> > > +           struct {
> > > +                   /* TODO: merge it with "mode" */
> > > +                   u8 admin:1;
> > > +                   u8 adv_enable;
> > > +                   u64 modes;
> > > +                   /* TODO: merge it with modes */
> > > +                   u32 mode;
> > > +                   u8 mdix;
> > > +           } phy;
> 
> Please can you also make use of __le64, __le32, __le16 in messages
> to/from the firmware, so sparse etc can help you catch were you are
> missing htonl(), htons() etc.
> 
>    Andrew
>

Makes sense, will fix in next patch set.

  Volodymyr