linux-kernel - Re: [Outreachy kernel] [PATCH 3/4] staging: rtl8723bs: core: Remove unnecessary space after a cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cfb2624-4e64-2d7f-a1e7-5032a3078ec9@gmail.com>
Date:   Fri, 22 Oct 2021 08:18:43 +0530
From:   Praveen Kumar <kpraveen.lkml@...il.com>
To:     Kushal Kothari <kushalkothari285@...il.com>,
        gregkh@...uxfoundation.org
Cc:     fabioaiuto83@...il.com, ross.schm.dev@...il.com,
        fmdefrancesco@...il.com, marcocesati@...il.com,
        straube.linux@...il.com, philippesdixon@...il.com,
        manuelpalenzuelamerino@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, mike.rapoport@...il.com,
        kushalkotharitest@...glegroups.com,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH 3/4] staging: rtl8723bs: core: Remove
 unnecessary space after a cast

On 22-10-2021 01:27, Kushal Kothari wrote:
> Issue found with checkpatch.pl.
> Space after cast is not needes

*needed

> 
> Signed-off-by: Kushal Kothari <kushalkothari285@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 88f6b7405106..fce3256cc275 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -922,7 +922,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_
>  	memcpy(psetstakey_para->addr, sta->hwaddr, ETH_ALEN);
>  
>  	if (check_fwstate(pmlmepriv, WIFI_STATION_STATE))
> -		psetstakey_para->algorithm = (unsigned char) psecuritypriv->dot11PrivacyAlgrthm;
> +		psetstakey_para->algorithm = (unsigned char)psecuritypriv->dot11PrivacyAlgrthm;
>  	else
>  		GET_ENCRY_ALGO(psecuritypriv, sta, psetstakey_para->algorithm, false);
>  
> @@ -951,7 +951,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_
>  		}
>  
>  		init_h2fwcmd_w_parm_no_rsp(ph2c, psetstakey_para, _SetStaKey_CMD_);
> -		ph2c->rsp = (u8 *) psetstakey_rsp;
> +		ph2c->rsp = (u8 *)psetstakey_rsp;
>  		ph2c->rspsz = sizeof(struct set_stakey_rsp);
>  		res = rtw_enqueue_cmd(pcmdpriv, ph2c);
>  	} else {
> @@ -1002,7 +1002,7 @@ u8 rtw_clearstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 enqueu
>  		}
>  
>  		init_h2fwcmd_w_parm_no_rsp(ph2c, psetstakey_para, _SetStaKey_CMD_);
> -		ph2c->rsp = (u8 *) psetstakey_rsp;
> +		ph2c->rsp = (u8 *)psetstakey_rsp;
>  		ph2c->rspsz = sizeof(struct set_stakey_rsp);
>  
>  		memcpy(psetstakey_para->addr, sta->hwaddr, ETH_ALEN);
> @@ -2027,7 +2027,7 @@ void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *pc
>  {
>  
>  	struct sta_priv *pstapriv = &padapter->stapriv;
> -	struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *) (pcmd->rsp);
> +	struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
>  	struct sta_info *psta = rtw_get_stainfo(pstapriv, psetstakey_rsp->addr);
>  
>  	if (!psta)
> @@ -2042,7 +2042,7 @@ void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *
>  	struct sta_priv *pstapriv = &padapter->stapriv;
>  	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>  	struct set_assocsta_parm *passocsta_parm = (struct set_assocsta_parm *)(pcmd->parmbuf);
> -	struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *) (pcmd->rsp);
> +	struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *)(pcmd->rsp);
>  	struct sta_info *psta = rtw_get_stainfo(pstapriv, passocsta_parm->addr);
>  
>  	if (!psta)
> 

Regards,

~Praveen.