| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAKmqyKMMQ7UaUTaCBHWrrtT-W+s5-ERAx6H97oOdNyCoXG7ngg@mail.gmail.com>
Date: Fri, 22 Oct 2021 10:35:08 +1000
From: Alistair Francis <alistair23@...il.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc: Alistair Francis <alistair.francis@...nsource.wdc.com>,
linux-riscv <linux-riscv@...ts.infradead.org>,
linux-perf-users@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Namhyung Kim <namhyung@...nel.org>,
Jiri Olsa <jolsa@...hat.com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Mark Rutland <mark.rutland@....com>,
Davidlohr Bueso <dave@...olabs.net>,
Darren Hart <dvhart@...radead.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Thomas Gleixner <tglx@...utronix.de>,
Atish Patra <atish.patra@....com>,
Arnd Bergmann <arnd@...db.de>,
Alistair Francis <alistair.francis@....com>,
Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH v4 1/4] perf bench futex: Call the futex syscall from a function
On Thu, Oct 21, 2021 at 11:25 PM Arnaldo Carvalho de Melo
<arnaldo.melo@...il.com> wrote:
>
> Em Thu, Oct 21, 2021 at 08:39:17AM +1000, Alistair Francis escreveu:
> > From: Alistair Francis <alistair.francis@....com>
> >
> > In preparation for a more complex futex() function let's convert the
> > current macro into two functions. We need two functions to avoid
> > compiler failures as the macro is overloaded.
> >
> > This will allow us to include pre-processor conditionals in the futex
> > syscall functions.
> >
> > Signed-off-by: Alistair Francis <alistair.francis@....com>
> > Acked-by: Davidlohr Bueso <dbueso@...e.de>
> > ---
> > tools/perf/bench/futex.h | 43 ++++++++++++++++++++++++----------------
> > 1 file changed, 26 insertions(+), 17 deletions(-)
>
> Right after applying this one:
>
> In file included from bench/futex-hash.c:29:
> bench/futex.h: In function ‘futex_syscall’:
> bench/futex.h:52:61: error: ‘ts32’ undeclared (first use in this function); did you mean ‘s32’?
> 52 | return syscall(SYS_futex, uaddr, op | opflags, val, ts32, uaddr2, val3);
> | ^~~~
> | s32
Sorry about that. There is a copy and paste error here. I have fixed this patch.
Alistair
> bench/futex.h:52:61: note: each undeclared identifier is reported only once for each function it appears in
> bench/futex.h:49:82: error: unused parameter ‘timeout’ [-Werror=unused-parameter]
> 49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, struct timespec *timeout,
> | ~~~~~~~~~~~~~~~~~^~~~~~~
> bench/futex.h:53:1: error: control reaches end of non-void function [-Werror=return-type]
> 53 | }
> | ^
> cc1: all warnings being treated as errors
> make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/bench/futex-hash.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> In file included from bench/futex-wake-parallel.c:31:
> bench/futex.h: In function ‘futex_syscall’:
> bench/futex.h:52:61: error: ‘ts32’ undeclared (first use in this function); did you mean ‘s32’?
> 52 | return syscall(SYS_futex, uaddr, op | opflags, val, ts32, uaddr2, val3);
> | ^~~~
> | s32
> bench/futex.h:52:61: note: each undeclared identifier is reported only once for each function it appears in
> bench/futex.h:49:82: error: unused parameter ‘timeout’ [-Werror=unused-parameter]
> 49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, struct timespec *timeout,
> | ~~~~~~~~~~~~~~~~~^~~~~~~
> bench/futex.h:53:1: error: control reaches end of non-void function [-Werror=return-type]
> 53 | }
> | ^
> cc1: all warnings being treated as errors
> make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/bench/futex-wake-parallel.o] Error 1
> In file included from bench/futex-requeue.c:26:
> bench/futex.h: In function ‘futex_syscall’:
> bench/futex.h:52:61: error: ‘ts32’ undeclared (first use in this function); did you mean ‘s32’?
> 52 | return syscall(SYS_futex, uaddr, op | opflags, val, ts32, uaddr2, val3);
> | ^~~~
> | s32
> bench/futex.h:52:61: note: each undeclared identifier is reported only once for each function it appears in
> bench/futex.h:49:82: error: unused parameter ‘timeout’ [-Werror=unused-parameter]
> 49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, struct timespec *timeout,
> | ~~~~~~~~~~~~~~~~~^~~~~~~
> bench/futex.h:53:1: error: control reaches end of non-void function [-Werror=return-type]
> 53 | }
> | ^
> cc1: all warnings being treated as errors
> In file included from bench/futex-lock-pi.c:19:
> bench/futex.h: In function ‘futex_syscall’:
> bench/futex.h:52:61: error: ‘ts32’ undeclared (first use in this function); did you mean ‘s32’?
> 52 | return syscall(SYS_futex, uaddr, op | opflags, val, ts32, uaddr2, val3);
> | ^~~~
> | s32
> bench/futex.h:52:61: note: each undeclared identifier is reported only once for each function it appears in
> bench/futex.h:49:82: error: unused parameter ‘timeout’ [-Werror=unused-parameter]
> 49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, struct timespec *timeout,
> | ~~~~~~~~~~~~~~~~~^~~~~~~
> bench/futex.h:53:1: error: control reaches end of non-void function [-Werror=return-type]
> 53 | }
> | ^
> cc1: all warnings being treated as errors
> make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/bench/futex-requeue.o] Error 1
> make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/bench/futex-lock-pi.o] Error 1
> In file included from bench/futex-wake.c:25:
> bench/futex.h: In function ‘futex_syscall’:
> bench/futex.h:52:61: error: ‘ts32’ undeclared (first use in this function); did you mean ‘s32’?
> 52 | return syscall(SYS_futex, uaddr, op | opflags, val, ts32, uaddr2, val3);
> | ^~~~
> | s32
> bench/futex.h:52:61: note: each undeclared identifier is reported only once for each function it appears in
> bench/futex.h:49:82: error: unused parameter ‘timeout’ [-Werror=unused-parameter]
> 49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, struct timespec *timeout,
> | ~~~~~~~~~~~~~~~~~^~~~~~~
> bench/futex.h:53:1: error: control reaches end of non-void function [-Werror=return-type]
> 53 | }
> | ^
> cc1: all warnings being treated as errors
> make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/bench/futex-wake.o] Error 1
> make[3]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:139: bench] Error 2
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [Makefile.perf:660: /tmp/build/perf/perf-in.o] Error 2
> make[1]: *** [Makefile.perf:240: sub-make] Error 2
> make: *** [Makefile:113: install-bin] Error 2
> make: Leaving directory '/var/home/acme/git/perf/tools/perf'
>
> Performance counter stats for 'make -k BUILD_BPF_SKEL=1 CORESIGHT=1 PYTHON=python3 O=/tmp/build/perf -C tools/perf install-bin':
>
> 2,467.00 msec task-clock:u # 1.263 CPUs utilized
> 2,457.82 msec cpu-clock:u # 1.259 CPUs utilized
>
> 1.952573032 seconds time elapsed
>
> 1.444401000 seconds user
> 1.111434000 seconds sys
>
>
> ⬢[acme@...lbox perf]$
>
>
Powered by blists - more mailing lists