linux-kernel - 答复: [PATCH] rbtree: Remove unneeded check condition in rb_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a3a7c84bfb94d26a2d6e88e86f6edda@baidu.com>
Date:   Fri, 22 Oct 2021 04:19:22 +0000
From:   "Li,Rongqing" <lirongqing@...du.com>
To:     Michel Lespinasse <michel@...pinasse.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...nel.org" <mingo@...nel.org>
Subject: 答复: [PATCH] rbtree: Remove unneeded check condition in rb_find_first

Ping

-Li

> On Thu, Sep 30, 2021 at 03:16:36PM +0800, Li RongQing wrote:
> > the variable c is int type, so change the following condition
> >
> > 	 if (c <= 0) {
> >
> > 	 }
> > 	 else if (c > 0) {
> >
> > 	 }
> > as:
> > 	 if (c <= 0) {
> >
> > 	 }
> > 	 else {
> >
> > 	 }
> >
> > Spotted-by: Michel Lespinasse <<michel@...pinasse.org>>
> > Signed-off-by: Li RongQing <lirongqing@...du.com>
> > ---
> >  include/linux/rbtree.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/linux/rbtree.h b/include/linux/rbtree.h index
> > 235047d..d5ac8f7 100644
> > --- a/include/linux/rbtree.h
> > +++ b/include/linux/rbtree.h
> > @@ -294,7 +294,7 @@ static inline void rb_replace_node_cached(struct
> rb_node *victim,
> >  			if (!c)
> >  				match = node;
> >  			node = node->rb_left;
> > -		} else if (c > 0) {
> > +		} else {
> >  			node = node->rb_right;
> >  		}
> >  	}
> 
> Looks good to me, thanks for the fix.
> 
> Reviewed-by: Michel Lespinasse <michel@...pinasse.org>
> 
> --
> Michel "walken" Lespinasse