linux-kernel - Re: [PATCH] i2c: virtio: Add support for zero-length requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211022065808.2rvbr6nvollz5mz6@vireshk-i7>
Date:   Fri, 22 Oct 2021 12:28:08 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Jie Deng <jie.deng@...el.com>
Cc:     Wolfram Sang <wsa@...nel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Arnd Bergmann <arnd@...nel.org>,
        stratos-dev@...lists.linaro.org,
        Alex Bennée <alex.bennee@...aro.org>,
        cohuck@...hat.com,
        Vincent Whitchurch <vincent.whitchurch@...s.com>,
        linux-i2c@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, conghui.chen@...el.com
Subject: Re: [PATCH] i2c: virtio: Add support for zero-length requests

On 22-10-21, 14:51, Jie Deng wrote:
> > +	if (!virtio_has_feature(vdev, VIRTIO_I2C_F_ZERO_LENGTH_REQUEST)) {
> > +		dev_err(&vdev->dev, "Zero-length request feature is mandatory\n");
> > +		return -EINVAL;
> 
> 
> It might be better to return -EOPNOTSUPP ?

Maybe that or one of these:

#define	EBADE		52	/* Invalid exchange */
#define	EPROTO		71	/* Protocol error */
#define	EPFNOSUPPORT	96	/* Protocol family not supported */
#define	ECONNREFUSED	111	/* Connection refused */

Arnd, any suggestions ? This is about the mandatory feature not being offered by
the device.

-- 
viresh