linux-kernel - [PATCH] ACPI: CPPC: fix return value in register_pcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211022073910.14398-1-songkai01@inspur.com>
Date:   Fri, 22 Oct 2021 15:39:10 +0800
From:   Kai Song <songkai01@...pur.com>
To:     <rafael@...nel.org>, <lenb@...nel.org>
CC:     <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Kai Song <songkai01@...pur.com>
Subject: [PATCH] ACPI: CPPC: fix return value in register_pcc_channel()

It uses IS_ERR to judge the return value of
pcc_mbox_request_channel().If it is invalid, maybe we should
use PTR_ERR to get the correct return value.

Signed-off-by: Kai Song <songkai01@...pur.com>
---
 drivers/acpi/cppc_acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
index bd482108310c..0bbb5fa27ce7 100644
--- a/drivers/acpi/cppc_acpi.c
+++ b/drivers/acpi/cppc_acpi.c
@@ -503,7 +503,7 @@ static int register_pcc_channel(int pcc_ss_idx)
 		if (IS_ERR(pcc_data[pcc_ss_idx]->pcc_channel)) {
 			pr_err("Failed to find PCC channel for subspace %d\n",
 			       pcc_ss_idx);
-			return -ENODEV;
+			return PTR_ERR(pcc_data[pcc_ss_idx]->pcc_channel);
 		}
 
 		/*
-- 
2.27.0