linux-kernel - Re: [PATCH v2 1/2] percpu_ref: percpu_ref_tryget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdf7c768-47ad-78c4-a22a-f0f1a435b6f6@gmail.com>
Date:   Fri, 22 Oct 2021 10:22:30 +0100
From:   Pavel Begunkov <asml.silence@...il.com>
To:     Dennis Zhou <dennis@...nel.org>
Cc:     linux-block@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Christoph Lameter <cl@...ux.com>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH v2 1/2] percpu_ref: percpu_ref_tryget_live() version
 holding RCU

On 10/21/21 15:01, Dennis Zhou wrote:
> Hello,
> 
> On Thu, Oct 21, 2021 at 02:30:51PM +0100, Pavel Begunkov wrote:
>> Add percpu_ref_tryget_live_rcu(), which is a version of
>> percpu_ref_tryget_live() but the user is responsible for enclosing it in
>> a RCU read lock section.
>>
>> Signed-off-by: Pavel Begunkov <asml.silence@...il.com>
>> ---
>>   include/linux/percpu-refcount.h | 33 +++++++++++++++++++++++----------
>>   1 file changed, 23 insertions(+), 10 deletions(-)
>>
[...]
>> +
>>   /**
>>    * percpu_ref_tryget_live - try to increment a live percpu refcount
>>    * @ref: percpu_ref to try-get
> 
> Nit: it's dumb convention at this point, but do you mind copying this
> guy up. I like consistency.

Looks Jens already took it. If you still want it moved, do you mind
it in a separate patch?

And I'm not sure I follow where you want it to be, currently it's
right before percpu_ref_tryget_live, which uses it.

-- 
Pavel Begunkov