linux-kernel - Re: [PATCH 1/5] xen: add "not_essential" flag to struct xenbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Oct 2021 10:28:40 +0100
From:   Andrew Cooper <andrew.cooper3@...rix.com>
To:     Juergen Gross <jgross@...e.com>, <xen-devel@...ts.xenproject.org>,
        <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-fbdev@...r.kernel.org>
CC:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Stefano Stabellini <sstabellini@...nel.org>
Subject: Re: [PATCH 1/5] xen: add "not_essential" flag to struct xenbus_driver

On 22/10/2021 07:47, Juergen Gross wrote:
> When booting the xenbus driver will wait for PV devices to have
> connected to their backends before continuing. The timeout is different
> between essential and non-essential devices.
>
> Non-essential devices are identified by their nodenames directly in the
> xenbus driver, which requires to update this list in case a new device
> type being non-essential is added (this was missed for several types
> in the past).
>
> In order to avoid this problem, add a "not_essential" flag to struct
> xenbus_driver which can be set to "true" by the respective frontend.
>
> Set this flag for the frontends currently regarded to be not essential
> (vkbs and vfb) and use it for testing in the xenbus driver.
>
> Signed-off-by: Juergen Gross <jgross@...e.com>

Wouldn't it be better to annotate essential?  That way, when new misc
drivers come along, they don't by default block boot.

~Andrew