linux-kernel - [PATCH] media: tw5864: Disable PCI device when finished

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20211022100644.3447-1-kieran.bingham+renesas@ideasonboard.com>
Date:   Fri, 22 Oct 2021 11:06:44 +0100
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     linux-media@...r.kernel.org
Cc:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Bluecherry Maintainers <maintainers@...echerrydvr.com>,
        Anton Sviridenko <anton@...p.bluecherry.net>,
        Andrey Utkin <andrey.utkin@...p.bluecherry.net>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-kernel@...r.kernel.org (open list)
Subject: [PATCH] media: tw5864: Disable PCI device when finished

The cleanup in tw5864_finidev() neglected to disable the PCI device
after enabling it in tw5864_initdev().

Call pci_disable_device() after releasing the associated resources.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
---
 drivers/media/pci/tw5864/tw5864-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/pci/tw5864/tw5864-core.c b/drivers/media/pci/tw5864/tw5864-core.c
index fee3b7711901..5cae73e6fb9c 100644
--- a/drivers/media/pci/tw5864/tw5864-core.c
+++ b/drivers/media/pci/tw5864/tw5864-core.c
@@ -334,6 +334,7 @@ static void tw5864_finidev(struct pci_dev *pci_dev)
 	/* release resources */
 	iounmap(dev->mmio);
 	pci_release_regions(pci_dev);
+	pci_disable_device(pci_dev);
 
 	v4l2_device_unregister(&dev->v4l2_dev);
 }
-- 
2.30.2