linux-kernel - Re: [PATCH v4 0/8] Remove dependency on congestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <163486531001.17149.13533181049212473096@noble.neil.brown.name>
Date:   Fri, 22 Oct 2021 12:15:10 +1100
From:   "NeilBrown" <neilb@...e.de>
To:     "Mel Gorman" <mgorman@...hsingularity.net>
Cc:     "Andrew Morton" <akpm@...ux-foundation.org>,
        "Theodore Ts'o" <tytso@....edu>,
        "Andreas Dilger" <adilger.kernel@...ger.ca>,
        "Darrick J . Wong" <djwong@...nel.org>,
        "Matthew Wilcox" <willy@...radead.org>,
        "Michal Hocko" <mhocko@...e.com>,
        "Dave Chinner" <david@...morbit.com>,
        "Rik van Riel" <riel@...riel.com>,
        "Vlastimil Babka" <vbabka@...e.cz>,
        "Johannes Weiner" <hannes@...xchg.org>,
        "Jonathan Corbet" <corbet@....net>,
        "Linux-MM" <linux-mm@...ck.org>,
        "Linux-fsdevel" <linux-fsdevel@...r.kernel.org>,
        "LKML" <linux-kernel@...r.kernel.org>,
        "Mel Gorman" <mgorman@...hsingularity.net>
Subject: Re: [PATCH v4 0/8] Remove dependency on congestion_wait in mm/

On Tue, 19 Oct 2021, Mel Gorman wrote:
> Changelog since v3
> o Count writeback completions for NR_THROTTLED_WRITTEN only
> o Use IRQ-safe inc_node_page_state
> o Remove redundant throttling
> 
> This series is also available at
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/mel/linux.git mm-reclaimcongest-v4r2
> 
> This series that removes all calls to congestion_wait
> in mm/ and deletes wait_iff_congested. 

Thanks for this.
I don't have sufficient expertise for a positive review, but it seems to
make sense with one exception which I have commented on separately.

In general, I still don't like the use of wake_up_all(), though it won't
cause incorrect behaviour.

I would prefer the first patch would:
 - define NR_VMSCAN_THROTTLE
 - make reclaim_wait an array
 - spelled nr_reclaim_throttled as nr_writeback_throttled

rather than leaving those changes for the second patch.  I think that
would make review easier.

But these are minor and I'll not mention them again.

Thanks,
NeilBrown