linux-kernel - Re: [PATCH 1/3] i2c: designware: Enable async suspend / resume of designware devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d94d015-ebff-ee46-3726-9091fe3cdff4@linux.intel.com>
Date:   Fri, 22 Oct 2021 14:37:36 +0300
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Rajat Jain <rajatja@...gle.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        dtor@...gle.com
Cc:     rajatxjain@...il.com, dbasehore@...omium.org
Subject: Re: [PATCH 1/3] i2c: designware: Enable async suspend / resume of
 designware devices

On 10/22/21 5:28 AM, Rajat Jain wrote:
> Mark the designware devices for asynchronous suspend. With this, the
> resume for designware devices does not get stuck behind other unrelated
> devices (e.g. intel_backlight that takes hundreds of ms to resume,
> waiting for its parent devices).
> 
> Signed-off-by: Rajat Jain <rajatja@...gle.com>
> ---
>   drivers/i2c/busses/i2c-designware-platdrv.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 21113665ddea..2bd81abc86f6 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -293,6 +293,8 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
>   					DPM_FLAG_MAY_SKIP_RESUME);
>   	}
>   
> +	device_enable_async_suspend(&pdev->dev);
> +
>   	/* The code below assumes runtime PM to be disabled. */
>   	WARN_ON(pm_runtime_enabled(&pdev->dev));
>   
I guess same can be done to i2c_dw_pci_probe() too. I don't have any 
strong opinion should it be done in this patch or somewhere in the future.

Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>