linux-kernel - Re: [PATCH v2] crypto: octeontx2 - Use dma_alloc_noncoherent() instead of kzalloc/dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211022121102.GA28240@gondor.apana.org.au>
Date:   Fri, 22 Oct 2021 20:11:02 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     hch@...radead.org, caihuoqing@...du.com, bbrezillon@...nel.org,
        arno@...isbad.org, schalla@...vell.com, davem@...emloft.net,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] crypto: octeontx2 - Use dma_alloc_noncoherent()
 instead of kzalloc/dma_map_single()

Cai Huoqing <caihuoqing@...du.com> wrote:
>
> @@ -1489,11 +1482,9 @@ int otx2_cpt_discover_eng_capabilities(struct otx2_cptpf_dev *cptpf)
> 
>                cptpf->eng_caps[etype].u = be64_to_cpup(rptr);
>        }
> -       dma_unmap_single(&pdev->dev, rptr_baddr, len, DMA_BIDIRECTIONAL);
> +       dma_free_noncoherent(&pdev->dev, len, (void *)result, rptr_baddr, DMA_BIDIRECTIONAL);

Why the cast?

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt