linux-kernel - Re: [PATCH] hw_random: replace snprintf in show functions with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211022123621.GB6920@gondor.apana.org.au>
Date:   Fri, 22 Oct 2021 20:36:21 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Qing Wang <wangqing@...o.com>
Cc:     Matt Mackall <mpm@...enic.com>, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hw_random: replace snprintf in show functions with
 sysfs_emit

On Tue, Oct 12, 2021 at 08:26:01PM -0700, Qing Wang wrote:
> coccicheck complains about the use of snprintf() in sysfs show functions.
> 
> Fix the following coccicheck warning:
> drivers/char/hw_random/s390-trng.c:114:8-16: WARNING: use scnprintf or sprintf.
> drivers/char/hw_random/s390-trng.c:122:8-16: WARNING: use scnprintf or sprintf.
> 
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> 
> Signed-off-by: Qing Wang <wangqing@...o.com>
> ---
>  drivers/char/hw_random/s390-trng.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt