linux-kernel - Re: [PATCH] crypto: tcrypt - fix skcipher multi-buffer tests for 1420B blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Oct 2021 20:36:40 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Horia Geantă <horia.geanta@....com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Ard Biesheuvel <ardb@...nel.org>,
        Pankaj Gupta <pankaj.gupta@....com>,
        linux-crypto@...r.kernel.org, NXP Linux Team <linux-imx@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: tcrypt - fix skcipher multi-buffer tests for
 1420B blocks

On Fri, Oct 15, 2021 at 10:39:18AM +0300, Horia Geantă wrote:
> Commit ad6d66bcac77e ("crypto: tcrypt - include 1420 byte blocks in aead and skcipher benchmarks")
> mentions:
> > power-of-2 block size. So let's add 1420 bytes explicitly, and round
> > it up to the next blocksize multiple of the algo in question if it
> > does not support 1420 byte blocks.
> but misses updating skcipher multi-buffer tests.
> 
> Fix this by using the proper (rounded) input size.
> 
> Fixes: ad6d66bcac77e ("crypto: tcrypt - include 1420 byte blocks in aead and skcipher benchmarks")
> Signed-off-by: Horia Geantă <horia.geanta@....com>
> ---
>  crypto/tcrypt.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt