linux-kernel - [PATCH v2 00/13] fixes and cleanups for string I/O emulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211022153616.1722429-1-pbonzini@redhat.com>
Date:   Fri, 22 Oct 2021 11:36:03 -0400
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     mlevitsk@...hat.com, seanjc@...gle.com
Subject: [PATCH v2 00/13] fixes and cleanups for string I/O emulation

This series is split in two parts:

- patch 7 fixes a bug in string I/O emulation for SEV-ES, where
  the size of the GHCB buffer can exceed the size of vcpu->arch.pio_data.
  If that happens, we need to go over the GHCB buffer in multiple passes.
  There are some preliminary cleanups in patches 1/3/6 too.

- the other patches clean emulator_pio_in and emulator_pio_in_out.  The
  first changes (patches 2/3/5) are more localized; they make the final
  SEV code a little easier to follow, and they remove unnecessary
  function arguments so that it is clearer which functions consume
  vcpu->arch.pio and which don't.  Patches starting from 8 on, instead,
  remove all usage of vcpu->arch.pio unless a userspace KVM_EXIT_IO is
  required.  In the end, IN is split clearly into a function that
  (if needed) fills in vcpu->arch.pio, and one that is intended for
  completion callbacks and consumes it.

Tested by booting a SEV-ES guest and with "regular" kvm-unit-tests.

Paolo

Paolo Bonzini (13):
  KVM: SEV-ES: rename guest_ins_data to sev_pio_data
  KVM: x86: leave vcpu->arch.pio.count alone in emulator_pio_in_out
  KVM: SEV-ES: clean up kvm_sev_es_ins/outs
  KVM: x86: split the two parts of emulator_pio_in
  KVM: x86: remove unnecessary arguments from complete_emulator_pio_in
  KVM: SEV-ES: keep INS functions together
  KVM: SEV-ES: go over the sev_pio_data buffer in multiple passes if
    needed
  KVM: x86: inline kernel_pio into its sole caller
  KVM: x86: move all vcpu->arch.pio* setup in emulator_pio_in_out
  KVM: x86: wean in-kernel PIO from vcpu->arch.pio*
  KVM: x86: wean fast IN from emulator_pio_in
  KVM: x86: de-underscorify __emulator_pio_in
  KVM: SEV-ES: reuse advance_sev_es_emulated_ins for OUT too

 arch/x86/include/asm/kvm_host.h |   3 +-
 arch/x86/kvm/trace.h            |   2 +-
 arch/x86/kvm/x86.c              | 193 +++++++++++++++++++-------------
 3 files changed, 117 insertions(+), 81 deletions(-)

-- 
2.27.0