lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 22 Oct 2021 22:41:45 +0530
From:   Saurav Girepunje <>
To:     Greg KH <>
Subject: Re: [PATCH v3] staging: rtl8723bs: os_dep: simplify the return

On 14/10/21 8:19 pm, Greg KH wrote:
> On Thu, Oct 14, 2021 at 08:10:00PM +0530, Saurav Girepunje wrote:
>> Remove goto statement where function simply return value without doing
>> any cleanup action.
>> Simplify the return using goto label to avoid unneeded 'if' condition
>> check.
>> Remove the unneeded and redundant check of variable on goto.
>> Remove the assignment of NULL on local variable.
> You are saying _what_ you are doing here, but not _why_ you are doing
> this.  For example, this last sentance does not make sense, why would
> you want to do such a thing (hint, I know, but you need to explain it in
> the changelog...)
> It's getting better, but the changelog still needs work.  Often times
> that's the hardest part of writing a kernel patch.
> thanks,
> greg k-h

Thanks Greg for review. I will work on changelog and will send v4.


Powered by blists - more mailing lists