lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 23 Oct 2021 03:46:18 +0300
From:   Jarkko Sakkinen <>
Subject: Re: [PATCH v16 2/6] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()"

On Thu, 2021-10-21 at 15:05 +0300, wrote:
> From: Amir Mizinski <>
> tpm_tis_req_canceled() function is used to check if the caller requested
> to abort the current operation. It was found that in some cases
> tpm_tis_req_canceled() wrongly returned true.
> Since a cancel request sets the TPM_STS.commandReady field to TRUE, the
> tpm_tis_req_canceled() function should check only the TPM_STS.commandReady
> field value.
> The case for TPM_VID_WINBOND is wrong and was therefore removed.
> Also, the default comparison is wrong. Only cmdReady bit needs to be
> compared instead of the full lower status register byte.
> Fixes: 1f866057291f (tpm: Fix cancellation of TPM commands (polling mode))

Please go through the comments for 1/6 and fix the commit
for the rest of the patches.


Powered by blists - more mailing lists