linux-kernel - Re: [PATCH] riscv: cacheinfo: fix typo of homogenous

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <750f6239-154d-9190-24ff-ece033add638@infradead.org>
Date:   Sat, 23 Oct 2021 13:36:47 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Palmer Dabbelt <palmer@...belt.com>, georgedanielmangum@...il.com
Cc:     Paul Walmsley <paul.walmsley@...ive.com>, aou@...s.berkeley.edu,
        Atish Patra <Atish.Patra@....com>, peterz@...radead.org,
        wangkefeng.wang@...wei.com, will@...nel.org, tglx@...utronix.de,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: cacheinfo: fix typo of homogenous

On 10/23/21 1:30 PM, Palmer Dabbelt wrote:
> On Fri, 08 Oct 2021 13:56:25 PDT (-0700), georgedanielmangum@...il.com wrote:
>> Updates 'homonogenous' to 'homogenous' in comment.
> 
> I don't really know spelling that well, but checkpatch says
> 
>     WARNING: 'homogenous' may be misspelled - perhaps 'homogeneous'?
> 
> when applying this.  It looks like they're both words, but "homogeneous" is the right one?
> 

Internet search to grammar.com says:

To summarise, Earlier, homogenous was used as a scientific term, mainly in biology, but now it is almost obsolete, being replaced by homologous. Whereas, homogeneous is a common word, very much in use and means having similar or comparable characteristics.

Several web sites agree that homogeneous is currently preferable.

>>
>> Signed-off-by: hasheddan <georgedanielmangum@...il.com>
>> ---
>>  arch/riscv/kernel/cacheinfo.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/kernel/cacheinfo.c b/arch/riscv/kernel/cacheinfo.c
>> index 90deabfe63ea..ff98546b1152 100644
>> --- a/arch/riscv/kernel/cacheinfo.c
>> +++ b/arch/riscv/kernel/cacheinfo.c
>> @@ -29,7 +29,7 @@ static struct cacheinfo *get_cacheinfo(u32 level, enum cache_type type)
>>      /*
>>       * Using raw_smp_processor_id() elides a preemptability check, but this
>>       * is really indicative of a larger problem: the cacheinfo UABI assumes
>> -     * that cores have a homonogenous view of the cache hierarchy.  That
>> +     * that cores have a homogenous view of the cache hierarchy.  That
>>       * happens to be the case for the current set of RISC-V systems, but
>>       * likely won't be true in general.  Since there's no way to provide
>>       * correct information for these systems via the current UABI we're


-- 
~Randy