linux-kernel - Re: [PATCH] bpf: support BPF_PROG_QUERY for progs attached to sockmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <53eeb3e084bc4f7b8120516dd87d0517@huawei.com>
Date:   Sat, 23 Oct 2021 06:01:39 +0000
From:   "zhudi (E)" <zhudi2@...wei.com>
To:     John Fastabend <john.fastabend@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "andrii@...nel.org" <andrii@...nel.org>,
        "kafai@...com" <kafai@...com>,
        "songliubraving@...com" <songliubraving@...com>,
        "yhs@...com" <yhs@...com>,
        "kpsingh@...nel.org" <kpsingh@...nel.org>,
        "jakub@...udflare.com" <jakub@...udflare.com>
CC:     "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bpf: support BPF_PROG_QUERY for progs attached to sockmap

> Di Zhu wrote:
> > Right now there is no way to query whether BPF programs are
> > attached to a sockmap or not.
> >
> > we can use the standard interface in libbpf to query, such as:
> > bpf_prog_query(mapFd, BPF_SK_SKB_STREAM_PARSER, 0, NULL, ...);
> > the mapFd is the fd of sockmap.
> >
> > Signed-off-by: Di Zhu <zhudi2@...wei.com>
> > ---
> 
> LGTM, lets add a small test here as well
> 
>   ./tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> 
> Looks like we can just copy the sk_lookup.c test case which does
> the query tests for BPF_SK_LOOKUP.

 Thanks for your advice, I will add it in my patch.

> Also I don't think its required for this series, but a bpftool
> patch to query it would be useful as well if its doesn't just
> work with above.
> 
> Thanks!
> John