linux-kernel - Re: [PATCH] iio: frequency: adrf6780: Fix adrf6780_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 24 Oct 2021 13:14:51 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Antoniu Miclaus <antoniu.miclaus@...log.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] iio: frequency: adrf6780: Fix adrf6780_spi_{read,write}()

On Sat, Oct 23, 2021 at 04:43:33PM +0100, Jonathan Cameron wrote:
> On Fri, 22 Oct 2021 12:56:56 -0700
> Nathan Chancellor <nathan@...nel.org> wrote:
> 
> > Clang warns:
> > 
> > drivers/iio/frequency/adrf6780.c:117:1: error: all paths through this
> > function will call itself [-Werror,-Winfinite-recursion]
> > {
> > ^
> > drivers/iio/frequency/adrf6780.c:138:1: error: all paths through this
> > function will call itself [-Werror,-Winfinite-recursion]
> > {
> > ^
> > 2 errors generated.
> > 
> > The underscore variants should be used here.
> > 
> > Fixes: 63aaf6d06d87 ("iio: frequency: adrf6780: add support for ADRF6780")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/1490
> > Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> 
> Thanks Nathan, (bit embarrassed I missed this in review :(
> As you probably guessed I didn't run an llvm test this time - guess I should
> start doing that on a regular basis.
> 
> We obviously have plenty of time to get this fix in place but
> seeing as I just sent a pull request for the driver a few hours before this
> patch:
> 
> Greg, would you mind picking this one up directly on top of
> [PULL] 2nd set of IIO new device support, features, cleanup for 5.16 
> if you take that pull request?
> 
> Message ID for this one is:
> 
> 20211022195656.1513147-1-nathan@...nel.org
> 
> No problem if you'd rather I just queue this fix up for post merge
> window.
> 
> Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Picked it up now, thanks!

greg k-h