linux-kernel - [pdx86-platform-drivers-x86:review-hans 77/100] drivers/platform/x86/system76_acpi.c:295: undefined reference to `battery_hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 24 Oct 2021 20:32:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Tim Crawford <tcrawford@...tem76.com>
Cc:     kbuild-all@...ts.01.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: [pdx86-platform-drivers-x86:review-hans 77/100]
 drivers/platform/x86/system76_acpi.c:295: undefined reference to
 `battery_hook_unregister'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
head:   fc3341b4b55f46ad0846a22ae149d94bac6ce40b
commit: 76f7eba3e0a248af4cc4f302d95031fa2fb65fab [77/100] platform/x86: system76_acpi: Add battery charging thresholds
config: i386-randconfig-a002-20211020 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=76f7eba3e0a248af4cc4f302d95031fa2fb65fab
        git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
        git fetch --no-tags pdx86-platform-drivers-x86 review-hans
        git checkout 76f7eba3e0a248af4cc4f302d95031fa2fb65fab
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

Note: the pdx86-platform-drivers-x86/review-hans HEAD fc3341b4b55f46ad0846a22ae149d94bac6ce40b builds fine.
      It only hurts bisectability.

All errors (new ones prefixed by >>):

   ld: drivers/platform/x86/system76_acpi.o: in function `system76_battery_exit':
>> drivers/platform/x86/system76_acpi.c:295: undefined reference to `battery_hook_unregister'
   ld: drivers/platform/x86/system76_acpi.o: in function `system76_battery_init':
>> drivers/platform/x86/system76_acpi.c:286: undefined reference to `battery_hook_register'


vim +295 drivers/platform/x86/system76_acpi.c

   279	
   280	static void system76_battery_init(void)
   281	{
   282		acpi_handle handle;
   283	
   284		handle = ec_get_handle();
   285		if (handle && acpi_has_method(handle, "GBCT"))
 > 286			battery_hook_register(&system76_battery_hook);
   287	}
   288	
   289	static void system76_battery_exit(void)
   290	{
   291		acpi_handle handle;
   292	
   293		handle = ec_get_handle();
   294		if (handle && acpi_has_method(handle, "GBCT"))
 > 295			battery_hook_unregister(&system76_battery_hook);
   296	}
   297	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (42469 bytes)