lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAH=2NtzMvXz6FRCApdxP1FFM9=73yfm07YibWGL-m0+KSkweaQ@mail.gmail.com> Date: Sun, 24 Oct 2021 19:04:32 +0530 From: Bhupesh Sharma <bhupesh.sharma@...aro.org> To: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org> Cc: MSM <linux-arm-msm@...r.kernel.org>, linux-crypto@...r.kernel.org, bhupesh.linux@...il.com, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, devicetree <devicetree@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>, Andy Gross <agross@...nel.org>, Herbert Xu <herbert@...dor.apana.org.au>, "David S . Miller" <davem@...emloft.net>, Thara Gopinath <thara.gopinath@...aro.org> Subject: Re: [PATCH v4 16/20] crypto: qce: core: Make clocks optional Hi Vladimir, On Thu, 14 Oct 2021 at 00:53, Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org> wrote: > > Hi Bhupesh, > > On 10/13/21 1:55 PM, Bhupesh Sharma wrote: > > From: Thara Gopinath <thara.gopinath@...aro.org> > > > > On certain Snapdragon processors, the crypto engine clocks are enabled by > > default by security firmware and the driver need not/ should not handle the > > clocks. Make acquiring of all the clocks optional in crypto enginer driver > > typo, s/enginer/engine/ > > > so that the driver intializes properly even if no clocks are specified in > > typo, s/intializes/initializes/ Thanks, I will fix these typos in v5. Regards, Bhupesh > > the dt. > > > > Signed-off-by: Thara Gopinath <thara.gopinath@...aro.org> > > --- > > drivers/crypto/qce/core.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > > index 2ab0b97d718c..576c416461f9 100644 > > --- a/drivers/crypto/qce/core.c > > +++ b/drivers/crypto/qce/core.c > > @@ -213,19 +213,19 @@ static int qce_crypto_probe(struct platform_device *pdev) > > if (IS_ERR(qce->mem_path)) > > return PTR_ERR(qce->mem_path); > > > > - qce->core = devm_clk_get(qce->dev, "core"); > > + qce->core = devm_clk_get_optional(qce->dev, "core"); > > if (IS_ERR(qce->core)) { > > ret = PTR_ERR(qce->core); > > goto err_mem_path_put; > > } > > > > - qce->iface = devm_clk_get(qce->dev, "iface"); > > + qce->iface = devm_clk_get_optional(qce->dev, "iface"); > > if (IS_ERR(qce->iface)) { > > ret = PTR_ERR(qce->iface); > > goto err_mem_path_put; > > } > > > > - qce->bus = devm_clk_get(qce->dev, "bus"); > > + qce->bus = devm_clk_get_optional(qce->dev, "bus"); > > if (IS_ERR(qce->bus)) { > > ret = PTR_ERR(qce->bus); > > goto err_mem_path_put; > > > > -- > Best wishes, > Vladimir
Powered by blists - more mailing lists