lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 24 Oct 2021 19:25:28 +0530
From:   Bhupesh Sharma <bhupesh.sharma@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        devicetree <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Thara Gopinath <thara.gopinath@...aro.org>,
        bhupesh.linux@...il.com, Andy Gross <agross@...nel.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        linux-crypto@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 05/20] dt-bindings: qcom-bam: Add 'interconnects' &
 'interconnect-names' to optional properties

Hi Rob,

On Thu, 14 Oct 2021 at 12:33, Bhupesh Sharma <bhupesh.sharma@...aro.org> wrote:
>
> Hello Rob,
>
> Thanks for your review.
> These issues are already fixed via patches within this series itself
> (as some dts also need correction to pass the 'make dtbs_check'
> check). I am not sure, but it seems the check was run without applying
> other patches from this series.
>
> See details below:
>
> On Thu, 14 Oct 2021 at 00:09, Rob Herring <robh@...nel.org> wrote:
> >
> > On Wed, 13 Oct 2021 16:25:26 +0530, Bhupesh Sharma wrote:
> > > Add new optional properties - 'interconnects' and
> > > 'interconnect-names' to the device-tree binding documentation for
> > > qcom-bam DMA IP.
> > >
> > > These properties describe the interconnect path between bam and main
> > > memory and the interconnect type respectively.
> > >
> > > Cc: Thara Gopinath <thara.gopinath@...aro.org>
> > > Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> > > Cc: Rob Herring <robh+dt@...nel.org>
> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
> > > ---
> > >  Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > >
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/1540390
> >
> >
> > dma@...42000: $nodename:0: 'dma@...42000' does not match '^dma-controller(@.*)?$'
> >         arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml
> >
> > dma@...82000: $nodename:0: 'dma@...82000' does not match '^dma-controller(@.*)?$'
> >         arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> >         arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> >         arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> >         arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq8064-ap148.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq8064-rb3011.dt.yaml
> >         arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml
> >
> > dma@...c2000: $nodename:0: 'dma@...c2000' does not match '^dma-controller(@.*)?$'
> >         arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> >         arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> >         arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> >         arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> >
> > dma@...02000: $nodename:0: 'dma@...02000' does not match '^dma-controller(@.*)?$'
> >         arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> >         arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> >         arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> >         arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq8064-ap148.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq8064-rb3011.dt.yaml
> >
> > dma@...4000: $nodename:0: 'dma@...4000' does not match '^dma-controller(@.*)?$'
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml
>
> All the above will be fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' &
>  'qcom,controlled-remotely' nodes in dts' in this series. See the git
> log of the this patch for details:
>
> 'A few qcom device-tree files define dma-controller nodes
> with non-standard 'node names' and also set
> the bool property 'qcom,controlled-remotely' incorrectly, which
> leads to following errors with 'make dtbs_check':
>
>  $ arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml:
>      dma@...4000: $nodename:0: 'dma@...4000' does not match
>      '^dma-controller(@.*)?$'
>
>  $ arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml:
>      dma@...4000: qcom,controlled-remotely: 'oneOf' conditional
>      failed, one must be fixed:
>     [[1]] is not of type 'boolean'
>     True was expected
>     [[1]] is not of type 'null'
>
> Fix the same.
> '
>
> > dma@...4000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+'
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml
>
> Fixed by ' [PATCH 06/20] dt-bindings: qcom-bam: Add 'iommus' to optional
>  properties ' in this series.
>
> > dma@...4000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed:
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml
>
> Again this would be fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' &
>  'qcom,controlled-remotely' nodes in dts' in this series.
>
> > dma@...000: $nodename:0: 'dma@...000' does not match '^dma-controller(@.*)?$'
> >         arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml
> >         arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml
> >         arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml
>
> Fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' &
> 'qcom,controlled-remotely' nodes in dts' in this series
>
> > dma@...000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed:
> >         arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml
> >         arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml
> >         arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml
>
> Fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' &
> 'qcom,controlled-remotely' nodes in dts' in this series
>
> > dma@...4000: $nodename:0: 'dma@...4000' does not match '^dma-controller(@.*)?$'
> >         arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml
> >         arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml
> >
> > dma@...4000: $nodename:0: 'dma@...4000' does not match '^dma-controller(@.*)?$'
> >         arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml
> >         arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml
> >
> > dma@...4000: $nodename:0: 'dma@...4000' does not match '^dma-controller(@.*)?$'
> >         arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml
> >
> > dma@...4000: $nodename:0: 'dma@...4000' does not match '^dma-controller(@.*)?$'
> >         arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml
> >
> > dma@...4000: $nodename:0: 'dma@...4000' does not match '^dma-controller(@.*)?$'
> >         arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml
> >         arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml
> >
> > dma@...4000: $nodename:0: 'dma@...4000' does not match '^dma-controller(@.*)?$'
> >         arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml
> >         arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml
>
> All the above 6 issues are fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' &
>  'qcom,controlled-remotely' nodes in dts' in this series.
>
> > dma-controller@...84000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+'
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml
> >         arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml
>
> Fixed by ' [PATCH 06/20] dt-bindings: qcom-bam: Add 'iommus' to optional
>  properties ' in this series.
>
> > dma-controller@...000: 'qcom,config-pipe-trust-reg' does not match any of the regexes: 'pinctrl-[0-9]+'
> >         arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml
>
> Fixed by '[PATCH 02/20] arm64/dts: qcom: ipq6018: Remove unused
>  'qcom,config-pipe-trust-reg' property' in this series.
>
> > dma-controller@...000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed:
> >         arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml
>
> Fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' &
> ''qcom,controlled-remotely' nodes in dts' in this series.
>
> > dma-controller@...4000: clock-names:0: 'bam_clk' was expected
> >         arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml
> >
> > dma-controller@...4000: clock-names: Additional items are not allowed ('bam_clk' was unexpected)
> >         arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml
> >
> > dma-controller@...4000: clock-names: ['iface_clk', 'bam_clk'] is too long
> >         arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml
> >
> > dma-controller@...4000: clocks: [[9, 138], [9, 137]] is too long
> >         arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml
>
> Fixed by '[PATCH 03/20] arm64/dts: qcom: ipq6018: Remove unused 'iface_clk'
> property from dma-controller node' in this series.
>
> In summary, I ran 'make dtbs_check' after applying this series on
> linus's tip and linux-next's tip as well and saw no errors being
> reported for 'Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml'.

Ping. Do I need to fix anything in v5 or are the fixes regarding the
YAML documentation fine? I am about to send the v5.

Regards,
Bhupesh

Powered by blists - more mailing lists