lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YXTY6BdmKBa+jPeN@builder.lan> Date: Sat, 23 Oct 2021 22:54:16 -0500 From: Bjorn Andersson <bjorn.andersson@...aro.org> To: Doug Anderson <dianders@...omium.org> Cc: satya priya <skakit@...eaurora.org>, Vinod Koul <vkoul@...nel.org>, Matthias Kaehlcke <mka@...omium.org>, Stephen Boyd <swboyd@...omium.org>, Andy Gross <agross@...nel.org>, Rob Herring <robh+dt@...nel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, linux-arm-msm <linux-arm-msm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] arm64: dts: qcom: pmk8350: Make RTC disabled by default; enable on sc7280-idp On Mon 18 Oct 16:45 CDT 2021, Doug Anderson wrote: > Bjorn, > > On Wed, Sep 29, 2021 at 9:00 PM <skakit@...eaurora.org> wrote: > > > > On 2021-09-30 04:08, Douglas Anderson wrote: > > > The RTC on the pmk8350 is not useful on all boards. Some boards may > > > not provide backup power to the PMIC but might have another RTC on the > > > board that does have backup power. In this case it's better to not use > > > the RTC on the PMIC. > > > > > > At the moment, the only boards that includes this PMIC are sc7280-idp > > > and sc7280-idp2. On sc7280-idp I'm not aware of any other RTCs, but > > > sc7280-idp2 has a Chrome OS EC on it and this is intended to provide > > > the RTC for the AP. > > > > > > Let's do what we normally do for hardware that's not used by all > > > boards and set it to a default status of "disabled" and then enable it > > > on the boards that need it. > > > > > > NOTE: for sc7280-idp it's _possible_ we might also want to add > > > `allow-set-time;`. That could be the subject of a future patch if it > > > is indeed true. > > > > > > Signed-off-by: Douglas Anderson <dianders@...omium.org> > > > --- > > > > > > > Reviewed-by: Satya Priya <skakit@...eaurora.org> > > If you're still accepting patches for 5.16, it'd be keen if you'd > consider taking this one. Thanks! > I've picked the patch and hope to get it included in v5.16. I do however not understand why the commit message so clearly defines that the only device including pmk8350 is the sc7280 idp when the sm8350-mtp.dts contains the following line: #include "pmk8350.dtsi" Perhaps I'm missing something obvious, but I took the liberty of also enabling the RTC in the SM8350 MTP. Regards, Bjorn
Powered by blists - more mailing lists