linux-kernel - Re: [PATCH] staging: r8188eu: Remove four unused semaphores

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2067076.ETZ9WjcDCG@localhost.localdomain>
Date:   Sun, 24 Oct 2021 18:27:11 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove four unused semaphores

On Sunday, October 24, 2021 2:30:11 PM CEST Greg Kroah-Hartman wrote:
> On Fri, Oct 22, 2021 at 01:39:36PM +0200, Fabio M. De Francesco wrote:
> > Remove four initialized but unused semaphores.
> > 
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> 
> What semaphores were removed?  Please be specific.
> 
> And can this be broken up into "one removal per patch?"
> 
> thanks,
> 
> greg k-h
> 
Hi Greg,

With all due respect (I mean it), I must say that I'm not going to split this 
trivial work into four patches of two lines each.

I understand that here you have the last word. After all, yours the tree, 
yours the rules. 

However, I'm used to do only what I can understand. After noticing that you 
can take in one shot the removal of 7000 unnecessary lines (e.g., please see 
commit 7bdedfef085b), I really cannot understand why you cannot take also the 
removal of four initialised but unused variables in one only go.

I'm really sorry but, if you cannot reconsider your decision, please drop 
this patch. I'm pretty sure that someone else is willing to do what you 
required, but not me.

Best regards,

Fabio