lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20211024185427.GA1420234@embeddedor> Date: Sun, 24 Oct 2021 13:54:27 -0500 From: "Gustavo A. R. Silva" <gustavoars@...nel.org> To: Matthew Wilcox <willy@...radead.org> Cc: Len Baker <len.baker@....com>, Kees Cook <keescook@...omium.org>, Luis Chamberlain <mcgrof@...nel.org>, Iurii Zaikin <yzaikin@...gle.com>, linux-hardening@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2][next] sysctl: Avoid open coded arithmetic in memory allocator functions On Sun, Oct 24, 2021 at 06:55:13PM +0100, Matthew Wilcox wrote: > On Sun, Oct 24, 2021 at 11:13:28AM +0200, Len Baker wrote: > > I think it's better for code to be understandable. Your patch makes > the code less readable in the name of "security", which is a poor > justification. I agree with Matthew. Those functions seem to be a bit too much, for now. Let's keep it simple and start by replacing the open-coded instances when possible, first. Then we can dig much deeper depending on each particular case, taking into consideration readability, which is certainly important. Thanks -- Gustavo
Powered by blists - more mailing lists