linux-kernel - Re: [PATCH] mailbox: remove the error message when gce clk is defer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YXXBVTEbjPiBm1un@shell.armlinux.org.uk>
Date:   Sun, 24 Oct 2021 21:25:57 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     "jason-jh.lin" <jason-jh.lin@...iatek.com>
Cc:     Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Yongqiang Niu <yongqiang.niu@...iatek.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        hsinyi@...omium.org, fshao@...omium.org, nancy.lin@...iatek.com,
        singo.chang@...iatek.com
Subject: Re: [PATCH] mailbox: remove the error message when gce clk is defer

On Sun, Oct 24, 2021 at 12:48:31AM +0800, jason-jh.lin wrote:
> Remove the error message when gce clk is defer.
> 
> Signed-off-by: jason-jh.lin <jason-jh.lin@...iatek.com>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index fd5576a9f8b4..684b8aa1e445 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -577,7 +577,8 @@ static int cmdq_probe(struct platform_device *pdev)
>  				snprintf(clk_id, sizeof(clk_id), "%s%d", clk_name, alias_id);
>  				cmdq->clocks[alias_id].id = clk_id;
>  				cmdq->clocks[alias_id].clk = of_clk_get(node, 0);
> -				if (IS_ERR(cmdq->clocks[alias_id].clk)) {
> +				if (IS_ERR(cmdq->clocks[alias_id].clk) &&
> +				    PTR_ERR(cmdq->clocks[alias_id].clk) != -EPROBE_DEFER) {
>  					dev_err(dev, "failed to get gce clk: %d\n", alias_id);
>  					return PTR_ERR(cmdq->clocks[alias_id].clk);
>  				}

So when you get -EPROBE_DEFER, you omit the error message _and_ ignore
the -EPROBE_DEFER. Is that really what you want to do?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!