lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACRpkdZCMH5OBwfiPwMT1CifDV28H4aTxy_N_4dHs0Qg0ENOAw@mail.gmail.com> Date: Sun, 24 Oct 2021 23:49:44 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Shreeya Patel <shreeya.patel@...labora.com> Cc: Bartosz Golaszewski <bgolaszewski@...libre.com>, Wolfram Sang <wsa@...nel.org>, krisman@...labora.com, Sebastian Reichel <sebastian.reichel@...labora.com>, Collabora Kernel ML <kernel@...labora.com>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, linux-i2c <linux-i2c@...r.kernel.org> Subject: Re: [PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL On Tue, Oct 19, 2021 at 12:05 AM Shreeya Patel <shreeya.patel@...labora.com> wrote: > We are racing the registering of .to_irq when probing the > i2c driver. This results in random failure of touchscreen > devices. > > Following errors could be seen in dmesg logs when gc->to_irq is NULL > > [2.101857] i2c_hid i2c-FTS3528:00: HID over i2c has not been provided an Int IRQ > [2.101953] i2c_hid: probe of i2c-FTS3528:00 failed with error -22 > > To avoid this situation, defer probing until to_irq is registered. > > This issue has been reported many times in past and people have been > using workarounds like changing the pinctrl_amd to built-in instead > of loading it as a module or by adding a softdep for pinctrl_amd into > the config file. > > References :- > https://bugzilla.kernel.org/show_bug.cgi?id=209413 > https://github.com/Syniurge/i2c-amd-mp2/issues/3 > > Signed-off-by: Shreeya Patel <shreeya.patel@...labora.com> > > --- > Changes in v2 > - Add a condition to check for irq chip to avoid bogus error. This v2 looks acceptable to me. Reviewed-by: Linus Walleij <linus.walleij@...aro.org> Yours, Linus Walleij
Powered by blists - more mailing lists