linux-kernel - Re: [PATCH 0/3] nolibc fixes marked for -stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211024225239.GJ880162@paulmck-ThinkPad-P17-Gen-1>
Date:   Sun, 24 Oct 2021 15:52:39 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Willy Tarreau <w@....eu>
Cc:     Bedirhan KURT <windowz414@...weeb.org>,
        Louvian Lyndal <louvianlyndal@...il.com>,
        Ammar Faizi <ammar.faizi@...dents.amikom.ac.id>,
        Peter Cordes <peter@...des.ca>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] nolibc fixes marked for -stable

On Sun, Oct 24, 2021 at 07:28:13PM +0200, Willy Tarreau wrote:
> Hi Paul,
> 
> here are a few fixes for nolibc. Ammar Faizi figured that the stack was
> not properly aligned on x86_64, it was aligned for after the call instead
> of before due to my misunderstanding of the spec. This made me check i386
> and I got it wrong there as well. Others are OK as they do not push but
> switch pointers on a call. The problem is essentially detected when using
> SIMD instructions (either voluntarily or when the compiler does it on its
> own).
> 
> A second (less important) issue is that I thought that it was up to the
> userland code to truncate the code passed to exit() to 8 bits while it's
> the kernel that does it. The difference is subtle but is visible in strace,
> and this was reported by Ammar as well. This time it affected all supported
> archs.
> 
> This series is based on 5.15-rc6. I marked them for backport to stable,
> just in case anyone uses nolibc for bisecting bugs.
> 
> Thanks!
> Willy

Queued for v5.17, thank you both!

							Thanx, Paul

> Ammar Faizi (1):
>   tools/nolibc: x86-64: Fix startup code bug
> 
> Willy Tarreau (2):
>   tools/nolibc: i386: fix initial stack alignment
>   tools/nolibc: fix incorrect truncation of exit code
> 
>  tools/include/nolibc/nolibc.h | 33 ++++++++++++++++++++++-----------
>  1 file changed, 22 insertions(+), 11 deletions(-)
> 
> -- 
> 2.17.5
>