linux-kernel - Re: [PATCH] mm: memcontrol: remove kmemcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YXbm+ow173NdCcP9@carbon.DHCP.thefacebook.com>
Date:   Mon, 25 Oct 2021 10:18:50 -0700
From:   Roman Gushchin <guro@...com>
To:     Muchun Song <songmuchun@...edance.com>
CC:     <akpm@...ux-foundation.org>, <mhocko@...nel.org>,
        <shakeelb@...gle.com>, <willy@...radead.org>, <hannes@...xchg.org>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: memcontrol: remove kmemcg_id reparenting

On Mon, Oct 25, 2021 at 08:51:02PM +0800, Muchun Song wrote:
> Since slab objects and kmem pages are charged to object cgroup instead
> of memory cgroup, memcg_reparent_objcgs() will reparent this cgroup and
> all its descendants to its parent cgroup. This already makes further
> list_lru_add()'s add elements to the parent's list. So it is unnecessary
> to change kmemcg_id of an offline cgroup to its parent's id. It just
> wastes CPU cycles. Just to remove those redundant code.
> 
> Signed-off-by: Muchun Song <songmuchun@...edance.com>

Acked-by: Roman Gushchin <guro@...com>

Thanks!